Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCU_LPC11U35_501: fix MCU inheritance #11828

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 6, 2019

Description (required)

Summary of change (What the change is for and why)

This should fix #11652 issue. Use proper inheritance for these targets. Otherwise there are duplicates in the build directory, it won't build.

This is for mbed 2 targets only.

@ruevs Please can you try to download this .json file and replace in your library, if it fixes your issue?

Documentation (Details of any document updates required)

None


Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@ciarmcom
Copy link
Member

ciarmcom commented Nov 6, 2019

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 7, 2019

cc @ARMmbed/team-seeed @toyowata

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 12, 2019

@ruevs Please review

I'll start CI now

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit f1848f9 into ARMmbed:master Nov 13, 2019
@0xc0170 0xc0170 deleted the fix_11652 branch November 13, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The online compiler fails to build the Xadow-M0 target with MBED2 rev. 142 and later.
4 participants