Add support for Makerdiary nRF52840-MDK

[manchoz]

Description

Add support for MakerDiary nRF52840-MDK.

Summary of change

Added target MAKERDIARY_NRF52840_MDK inheriting from MCU_NRF52840.

ITM support has been disabled because MakerDiary nRF52840-MDK uses TRACEDATA0 pin for on-board User Button.

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

[ciarmcom]

@manchoz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[0xc0170]

Can you also attach test logs as part of the new target addition PR

[0xc0170]

can you fix alignment in this file (line 93 to 107)

[manchoz]

Done

[manchoz]

Logs will follow because I need to move to a non MacOS machine in order to get the USB-related tests to pass.

[manchoz]

Please, find both full log and specific USB tests logs - run with various system adjustments - at following gist

https://gist.github.com/manchoz/de94b521c3edf0a3f771d27f70ed8b23

[0xc0170]

I reviewed the logs, there are some failures - in usb - what are these? any known issues?

[manchoz]

I reviewed the logs, there are some failures - in usb - what are these? any known issues?

Although I have followed all the indications for the configuration of files/devices permissions and udev, I'm having a lot of issues trying to get both GNU/Linux (Arch Linux w/ Gnome 3.34.1) and MacOS Catalina behaving properly during USB tests, because both interfere a lot with the USB operations of mbed test. (And due to Catalina complaining with "DAPLink disk non ejected properly" at every test suite the tests are running at least 2x slower)

I have performed several test sessions and the results for USB test are often different depending on the state of the OS. I'm currently trying to setup a barebone GNU/Linux testing machine in order to double check the test results.

[0xc0170]

Thanks for the feedback. You can report these to our forum or as an issue (if it is being technical), tests should be reproducible by anyone.

[0xc0170]

@maciejbocianski usb tests - have you seen these errors or someone else would know?

[0xc0170]

Ci started

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

[maciejbocianski]

@fkjagodzinski

[maciejbocianski]

@maciejbocianski usb tests - have you seen these errors or someone else would know?

@0xc0170 Checked NRF52840_DK and it looks it's only linux problem - can reproduce some (on windows works fine).
@manchoz Can you confirm that you applied all steps from https://github.com/ARMmbed/mbed-os/blob/master/TESTS/usb_device/README.md

[manchoz]

@maciejbocianski yes, every step done.

I have same results for USB tests on:

• MacBook Pro 13 2017 w/ MacOS Catalina
• Lenovo Thinkpad X220 w/ Arch Linux (w/ and w/o sudo)
• FriendlyElec Nano Pi Neo2 w/ Armbian Buster (w/ and w/o sudo)

[0xc0170]

I accidentally started another CI run, will complete soon

[0xc0170]

@manchoz I believe these issues should be reported via new issues.

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

[manchoz]

@0xc0170 a different on from #11912?

[manchoz]

@0xc0170 thank you for merging.

[0xc0170]

@0xc0170 a different on from #11912?

I see, that should be sufficient.