-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pycryptodome version #11866
Update pycryptodome version #11866
Conversation
@Devran01, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues on Mbed side, how about @ARMmbed/mbed-os-tools ?
@ARMmbed/mbed-os-test This might require an update in our CI as well, please review I'll run initial CI that might fail |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to see evidence of testing on windows, mac and Linux; also on the version of GCC, ARM CC and IAR compilers that we are currently using.
requirements.txt
Outdated
@@ -19,7 +19,7 @@ beautifulsoup4>=4,<=4.6.3 | |||
pyelftools>=0.24,<=0.25 | |||
manifest-tool==1.5.2 | |||
icetea>=1.2.1,<1.3 | |||
pycryptodome>=3.7.2,<=3.7.3 | |||
pycryptodome==3.9.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using >=3.9.3,<4 here, rather than pinning the version
pycryptodome==3.9.3 | |
pycryptodome>=3.9.3,<4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-edgeworth Agreed. Fixed.
We should be able to run at least this one in CI (manual run). @VeliMattiLahtela should be able to help to get this tested @Devran01 Please talk to him |
The required version of pycryptodome currently is either 3.7.2 or 3.7.3. But there is no wheel package for these version for latest version of python (3.8). Due to this, pip will download source and compile while trying to install pycryptodome. On Windows, there is no c, c++ compiler installed by default which leads to pip asking users to download and install Microsoft Visual C++ Build Tools. The release version 3.9.3 contains wheel package for python 3.8 on all supported operating systems. Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
d2833ba
to
98ef548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this because it appears to offer better python 3 support and the docs suggest that the platform specific code is now included (it wasn't in the previous release). I've not tested this.
@0xc0170 Travis failure is caused by temporary failure |
Travis restarted |
As discussed, this is not ready for 5.15, moving to 6.0 |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Summary of change
The required version of pycryptodome currently is either 3.7.2 or 3.7.3.
But there is no wheel package for these version for latest version of python
(3.8). Due to this, pip will download source and compile while trying to
install pycryptodome. On Windows, there is no c, c++ compiler installed
by default which leads to pip asking users to download and install
Microsoft Visual C++ Build Tools.
The release version 3.9.3 contains wheel package for python 3.8 on
all supported operating systems.
Signed-off-by: Devaraj Ranganna devaraj.ranganna@arm.com
Documentation
None
Pull request type
Test results
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required
Fixes #11787