-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress Target update to support Manufacturing Test. #11868
Conversation
@balajicyp, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split styling changes to the update test code? these should be separate commits
@0xc0170 Martin I have removed the styling changes from this commit, Please have a look. Thanks |
@@0xc0170 Any update on this? We want this to be merged in release 5.14.2 |
The code freeze was prior even this PR was created (I see this one referencing 5.14.2 just yesterday, we already have release candidate). I set this to 5.15 .
Looks better but do not understand why the second commit is merge commit if this contains just styling changes, can you rebase and fix it - should be a regular commit instead. Otherwise all looks fine to me. |
Fix WHD EMAC interface to release buffer when emac is not powered up or callback is not registered.
MBED-OS changes for adding IOCTLS in WhdSTAInterface for MFG Test. Fix WHD EMAC interface to release buffer when emac is not powered up or callback is not registered.
MBED-OS changes for adding IOCTLS in WhdSTAInterface for MFG Test. Fix WHD EMAC interface to release buffer when emac is not powered up or callback is not registered.
64f20f3
to
58fe1ac
Compare
@0xc0170 , Thanks Martin, Yes 5.15 is fine . Next time I will mention the release version when I do a pull request. I have fixed the merge commit and re-based my code, please check. |
What you could do is to rebase and remove first two commits as they are emtpy. We will merge them with squash to have one unified commit. Starting CI |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Thanks @0xc0170 (Martin) for your help! |
Description (required)
Cypress Target Update to support WLAN manufacturing test.
Summary of change (What the change is for and why)
Add IOCTL(s) to get/set from the Host to WLAN device
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required