Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Target update to support Manufacturing Test. #11868

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

balajicyp
Copy link
Contributor

Description (required)

Cypress Target Update to support WLAN manufacturing test.

Summary of change (What the change is for and why)

Add IOCTL(s) to get/set from the Host to WLAN device

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@ciarmcom ciarmcom requested review from a team November 14, 2019 20:00
@ciarmcom
Copy link
Member

@balajicyp, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split styling changes to the update test code? these should be separate commits

@balajicyp
Copy link
Contributor Author

@0xc0170 Martin

I have removed the styling changes from this commit, Please have a look.

Thanks
Balaji

@balajicyp
Copy link
Contributor Author

@@0xc0170 Any update on this? We want this to be merged in release 5.14.2

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2019

@0xc0170 Any update on this? We want this to be merged in release 5.14.2

The code freeze was prior even this PR was created (I see this one referencing 5.14.2 just yesterday, we already have release candidate). I set this to 5.15 .
Please always state specific version requests as soon as possible (when creating a pull request).

I have removed the styling changes from this commit, Please have a look.

Looks better but do not understand why the second commit is merge commit if this contains just styling changes, can you rebase and fix it - should be a regular commit instead.

Otherwise all looks fine to me.

Fix WHD EMAC interface to release buffer when emac is not powered up or callback
is not registered.
MBED-OS changes for adding IOCTLS in WhdSTAInterface for MFG Test.
Fix WHD EMAC interface to release buffer when emac is not powered up or callback
is not registered.
MBED-OS changes for adding IOCTLS in WhdSTAInterface for MFG Test.
Fix WHD EMAC interface to release buffer when emac is not powered up or callback
is not registered.
@balajicyp
Copy link
Contributor Author

@0xc0170 , Thanks Martin, Yes 5.15 is fine . Next time I will mention the release version when I do a pull request.

I have fixed the merge commit and re-based my code, please check.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2019

The update looks fine , there are just 2 commits that are empty. Please can you check? First two commits do not have any code change.

fab7c31 and 470ab8d are empty

@0xc0170 0xc0170 self-requested a review November 20, 2019 14:03
@balajicyp
Copy link
Contributor Author

@0xc0170 , I tried to squash changes but since commit fab7c31 , 470ab8d are empty it is showing as noop.

While merging my changes i accidently pushed empty commits.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 21, 2019

What you could do is to rebase and remove first two commits as they are emtpy.

We will merge them with squash to have one unified commit.

Starting CI

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit f51cc64 into ARMmbed:master Nov 21, 2019
@balajicyp
Copy link
Contributor Author

What you could do is to rebase and remove first two commits as they are emtpy.
We will merge them with squash to have one unified commit.
Starting CI

Thanks @0xc0170 (Martin) for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants