-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SMS configurable in Cellular stack #11873
Conversation
@AnttiKauppila, thank you for your changes. |
@@ -314,6 +314,7 @@ class CellularDevice { | |||
*/ | |||
virtual CellularNetwork *open_network(FileHandle *fh = NULL) = 0; | |||
|
|||
#if MBED_CONF_CELLULAR_USE_SMS || defined(DOXYGEN_ONLY) | |||
/** Create new CellularSMS interface. | |||
* | |||
* @param fh file handle used in communication to modem. This can be, for example, UART handle. If null, then the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the trick how to enable this via the mbed_app.json
target override be added here or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Activation tip somewhere, looks otherwise just fine!
Like I have put in mbed_lib.json? |
Well, that's not quite enough - we don't want people to modify the |
Please amend the commit msg with details shared above (why is this disabled). |
But Janne, this is the DEFAULT Mbed OS configuration mechanism, nobody should modify mbed_lib.json anywhere but override the config as per our documentation: https://os.mbed.com/docs/mbed-os/v5.14/reference/configuration.html What else do you need? |
Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features. UBlox N2XX target is also updated
64add0f
to
353782b
Compare
@0xc0170 Commit msg updated |
will start CI as soon as some 5.15 jobs complete |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features.
UBlox N2XX target is also updated
Summary of change (What the change is for and why)
Unittests have been updated also
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
@AriParkkila @mirelachirica @JanneKiiskila @anttiylitokola
Release Notes (required for feature/major PRs)
Summary of changes
Cellular stack has now configurable SMS support. This is added to Cellular mbed_lib.json. It is enabled by default for backward compatibility.
Impact of changes
If one does not need SMS, disable it in mbed_app.json to decrease the application footprint.
Migration actions required
None