Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target for CY8CPROTO-062S3-4343W #11886

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Add target for CY8CPROTO-062S3-4343W #11886

merged 2 commits into from
Nov 26, 2019

Conversation

kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented Nov 19, 2019 •
edited
Loading

Description (required)

Add target for Cypress board CY8CPROTO-062S3-4343W
This depends on PR #11884

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

GT_FT_PROTO_062S3_4343W_GCC_ARM.txt
NOTE: The kvstore failures are due to #11879. The sleep failures are due to a known incompatibility between the sleep tests and our UART driver.

GT_FT_PROTO_062S3_4343W-NET.txt
NOTE: The failures are known issues with the integration test suite which we recently enabled. They apply across Cypress targets and will be fixed in a future PR.

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers (optional)

@ARMmbed/team-cypress

Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@ciarmcom ciarmcom requested review from maclobdell and a team November 19, 2019 02:00
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

bulislaw
bulislaw reviewed Nov 19, 2019
View reviewed changes
targets/targets.json
"CY8CMOD_062S3_4343W": {
"inherits": ["MCU_PSOC6_M4"],
"features": ["BLE"],
"components_add": ["WHD", "4343W", "CYW43XXX"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these components? Are those drivers for external HW? If not they shouldn't be in components.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are drivers for the external Wifi and BT radio, which were changed to a component in #11840 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also CYW43XXX ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all three are related to external radio support.

@kyle-cypress
Copy link
Author

kyle-cypress commented Nov 19, 2019 •
edited
Loading

Pushed an update to remove board-specific PinNames.h that is made obsolete by #11884 .

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2019

IAR failures look related , please review

08:25:17  "/builds/ws/mbed-os-ci_build-IAR@4/mbed-os/targets/TARGET_Cypress/TARGET_PSOC6/COMPONENT_WHD/resources/firmware/COMPONENT_4343W/4343WA1_clm_blob.c",401  Error[Pe020]: identifier "wifi_firmware_clm_blob_image_data" is undefined

Kyle Kearney added 2 commits November 25, 2019 11:41
Add target for CY8CPROTO-062S3-4343W
ac8a8a6
Fix missing #include in wiced_resource.h
c736afa 
The `CY_PRAGMA` macro is used in certain build scenarios with IAR,
but it is not defined without including "cy_syslib.h"
@kyle-cypress
Copy link
Author

Rebased on master to pull in #11884 and pushed c736afa to fix the IAR build failure.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 2b2ec25 into ARMmbed:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bulislaw bulislaw bulislaw approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
devices: cypress release-version: 5.15.0-rc1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyle-cypress @ciarmcom @0xc0170 @mbed-ci @bulislaw