Minimal Console: Fix compilation error #11959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successfully when `platform.stdio-convert-tty-newlines` or `platform.stdio-convert-newlines` are set to `true` by ensuring `isatty()` is also included when `platform.stdio-minimal-console-only` is set to `true`.
0xc0170
approved these changes
Nov 27, 2019
evedon
approved these changes
Nov 27, 2019
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
tests restarted, there is another PR landing soon which should address these failures in kvstore |
|
We shall wait with this one, not yet ready. |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of change
Build successfully when
platform.stdio-convert-tty-newlinesorplatform.stdio-convert-newlinesare set totrueby ensuringisatty()is also included whenplatform.stdio-minimal-console-onlyis set to
true.Documentation
Pull request type
Test results
See: #11796 (comment)
Reviewers
@rajkan01 @evedon
Release Notes
Summary of changes
Impact of changes
Migration actions required