-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid crashes during fault handler #11970
Conversation
0130151
to
bc7e217
Compare
@kjbracey-arm, thank you for your changes. |
If the fault handler was hit before the stdio console was used and initialised, the initialisation code caused a "mutex in ISR" trap, stopping the register dump from happening. Temporarily set the `error_in_progress` flag at the top of the fault handler, and restore it before calling `mbed_error`. Take the opportunity to suppress fault dumps on recursive crashes, much as is done inside `mbed_error`.
bc7e217
to
fc05d51
Compare
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This is a pretty straightforward and important fix - it should be for 5.15.1 |
After 5.15, there will be 6.0. This could be requested to get in rc2. I'll merge this and we can fix version if agreed. |
Set to 5.15.0rc2 |
Description
Summary of change
If the fault handler was hit before the stdio console was used and initialised, the initialisation code caused a "mutex in ISR" trap, stopping the register dump from happening.
Temporarily set the
error_in_progress
flag at the top of the fault handler, and restore it before callingmbed_error
. Take the opportunity to suppress fault dumps on recursive crashes, much as is done insidembed_error
.Fixes #11584.
Pull request type
Test results