Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fix a bug introduced by static pinmap #12006

Merged
merged 1 commit into from
Dec 3, 2019
Merged

FIX: fix a bug introduced by static pinmap #12006

merged 1 commit into from
Dec 3, 2019

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Dec 2, 2019 •
edited
Loading

Description

Summary of change

This PR fix the flow control pin check missing issue which introduced by static pinmap

https://github.com/ARMmbed/mbed-os/pull/11892/files?file-filters%5B%5D=.c&file-filters%5B%5D=.h&file-filters%5B%5D=.md&file-filters%5B%5D=.png&file-filters%5B%5D=No+extension#diff-751f39265e175642418e86d92d8fd20aL418-R446

Documentation

not required

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @mprse

Release Notes

Summary of changes

Impact of changes

Migration actions required

@ciarmcom ciarmcom requested review from 0xc0170, maclobdell, mprse and a team December 2, 2019 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 2, 2019

@jamesbeyond, thank you for your changes.
@mprse @0xc0170 @maclobdell @ARMmbed/mbed-os-maintainers please review.

fkjagodzinski
fkjagodzinski approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2019

Set for 5.15.0 rc2

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit c098bdf into ARMmbed:master Dec 3, 2019
@0xc0170 0xc0170 removed the needs: CI label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprse mprse mprse approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.15.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesbeyond @ciarmcom @0xc0170 @mbed-ci @fkjagodzinski @mprse