Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STMOD_CELLULAR: improve debug print #12011

Merged
merged 1 commit into from
Dec 4, 2019
Merged

STMOD_CELLULAR: improve debug print #12011

merged 1 commit into from
Dec 4, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Summary of change

Improve mbed_trace in STMOD CELLULAR component

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@LMESTM

Release Notes

Summary of changes

Impact of changes

Migration actions required

kivaisan
kivaisan suggested changes Dec 3, 2019
View reviewed changes
features/cellular/framework/AT/AT_CellularContext.cpp Outdated
@@ -319,6 +319,7 @@ void AT_CellularContext::set_credentials(const char *apn, const char *uname, con
_apn = apn;
_uname = uname;
_pwd = pwd;
tr_info("set_credentials APN %s USERNAME %s PASSWORD %s", _apn, _uname, _pwd);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracing credentials is not allowed. Please remove.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ciarmcom ciarmcom requested a review from a team December 3, 2019 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 3, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2019

CI started

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 3, 2019
@mbed-ci
Copy link

mbed-ci commented Dec 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 4, 2019
@0xc0170 0xc0170 merged commit 020e508 into ARMmbed:master Dec 4, 2019
@jeromecoutant jeromecoutant deleted the PR_STMOD_DEBUG branch December 4, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivaisan kivaisan kivaisan approved these changes

@LMESTM LMESTM LMESTM approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @LMESTM @kivaisan