Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA setup template changes. #12085

Merged
merged 1 commit into from
Dec 16, 2019
Merged

PSA setup template changes. #12085

merged 1 commit into from
Dec 16, 2019

Conversation

jainvikas8
Copy link
Contributor

@jainvikas8 jainvikas8 commented Dec 11, 2019 •
edited
Loading

Fixes #12084

Summary of changes

Astyle issue for PSA auto-generated files during release therefore removed spaces for the problematic line.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

python tools/psa/release.py -t <tool> -m <target> --commit

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jainvikas8
PSA setup template changes.
4a84e14 
Ideally, there is nothing wrong, but it seems to produce AStyle
error when release script runs for PSA Auto-generated files.
Therefore removed the spaces from the problematic line.

Fixes ARMmbed#12084

Signed-off-by: Vikas Katariya <Vikas.Katariya@arm.com>
@ciarmcom ciarmcom requested review from a team December 11, 2019 16:00
@ciarmcom
Copy link
Member

@jainvikas8, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

CI started while awaiting review

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 16, 2019
@0xc0170 0xc0170 merged commit f77f4ea into ARMmbed:master Dec 16, 2019
@jainvikas8 jainvikas8 mentioned this pull request Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astyle issue for PSA auto-generated files during release
5 participants
@jainvikas8 @ciarmcom @adbridge @mbed-ci @0xc0170