Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of code fixed #12098

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Wrong order of code fixed #12098

merged 1 commit into from
Dec 17, 2019

Conversation

AnttiKauppila
Copy link

The source file had dead code because code was behind return and therefore unreachable. Order was changed to have correct behaviour

Summary of changes

The source file had dead code because code was behind return and therefore unreachable. Order was changed to have correct behaviour

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


The source file had dead code because code was behind return and therefore unreachable. Order was changed to have correct behaviour
@AnttiKauppila AnttiKauppila requested a review from a team December 13, 2019 06:42
@ciarmcom ciarmcom requested review from a team December 13, 2019 08:00
@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 16, 2019
@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 03e29df into master Dec 17, 2019
@AnttiKauppila AnttiKauppila deleted the AnttiKauppila-patch-1 branch December 18, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants