Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented recommended fix from https://github.com/STMicroelectronic… #12099

Merged

Conversation

J91Olivier
Copy link

The baud rate was calculated incorrectly for STM32F4 targets that have UART9 and UART10 peripherals. A fix has been implemented as recommended from STMicroelectronics/STM32CubeF4#5.

Summary of changes

Ensures that the baud rate register value is calculated correctly for STM32F4 targets that have UART9 and UART10 peripherals.

When the targets clock frequency is configured such that APB1 is different from APB2 the baud rates for UART9 and UART10 will not be calculated correctly and the device will not have its expected baud rate when interfacing with other devices. This fixes #12090

Impact of changes

There are no implications for users that were not affected by this bug. It will only execute the fix for the devices that have a UART9 and UART10 peripheral.

Migration actions required

No mitigation actions are required for this fix.

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested review from jeromecoutant and a team December 13, 2019 10:00
@ciarmcom
Copy link
Member

@J91Olivier, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@jeromecoutant
Copy link
Collaborator

ST_INTERNAL_REF 50651

@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 8b0a5c2 into ARMmbed:master Dec 17, 2019
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed ready for merge labels Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32F4 UART baud rate calculation bug
7 participants