ATHandler refactoring #12122
Merged
ATHandler refactoring #12122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnttiKauppila, thank you for your changes. |
mirelachirica
approved these changes
Dec 18, 2019
bulislaw
approved these changes
Dec 23, 2019
|
CI started then noticing this needs a rebase due to a conflict. Please rebase |
added 2 commits
January 7, 2020 17:15
ATHandler is part of our API so header file was moved under API folder and .cpp file was moved under device/ folder ATHandler is used in both AT and PPP mode so it has been in slightly wrong place at the beginning.
Refactored ATHandler class to have clear private and public elements Also removed virtuality from ATHandler Unittests updated to reflect changes
AnttiKauppila
force-pushed
the
visibility_fixes
branch
from
c0f6f44 to
5553d0a
Compare
|
CI restarted |
As github does not notify anyone when forced push, please just bump the PR with a note about being updated , thanks. |
0xc0170
added
the
release-version: 6.0.0-alpha-1
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As ATHandler is part of Cellular's public API it is now moved to /API folder
Also some functions and variables are refactored to be private/protected where applicable
Also virtual cmd_start() (and destructor) method(s) devirtualised because not needed.
Unittests updated to reflect changes
Impact of changes
As ATHandler is part of Cellular's public API it is now moved to /API folder
Also some functions and variables are refactored to be private/protected where applicable
Also virtual cmd_start() (and destructor) method(s) devirtualised because not needed.
Migration actions required
Visibility of some methods have been changed in ATHandler and should not cause any issues if those were not used (as they shouldn't have been).
Also if include path has been used correctly for ATHandler.h there are no cahnges needed
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan