Robustify equeue multithread unit test #12126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than wait 10ms before breaking the other thread, and expecting at least one event to have been run, wait for one event to be run, then break. Should avoid some spurious failures that have been seen.
kjbracey
force-pushed
the
equeue_utest_robust
branch
from
4e0f61e to
2d37aa2
Compare
|
Failure seen today testing #12097 and others. |
|
@kjbracey-arm, thank you for your changes. |
kjbracey
changed the title
adbridge
requested changes
Dec 19, 2019
| void touch() | ||
| { | ||
| lock(); | ||
| if (count < 200) { |
There was a problem hiding this comment.
Why 200? What is the significance of this value ?
There was a problem hiding this comment.
It's from the original code.
Don't think it's particularly magic - it's using an 8-bit counter for "how many times was this called", but stops incrementing at 200 to avoid any wrap possibility.
adbridge
approved these changes
Dec 19, 2019
|
CI started |
Test run: SUCCESSSummary: 1 of 1 test jobs passed |
AnttiKauppila
approved these changes
Dec 20, 2019
|
That wasn't requested for 5.15.x as far as i can tell? |
|
Test change. Lets pull it in the next patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Rather than wait 10ms before breaking the other thread, and expecting at
least one event to have been run, wait for one event to be run, then
break.
Should avoid some spurious failures that have been seen.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers