Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWIP: Remove unused MBOX configs #12132

Merged

Conversation

michalpasztamobica
Copy link
Contributor

@michalpasztamobica michalpasztamobica commented Dec 18, 2019

Summary of changes

Remove the two MBOX config options which were ignored by LWIP. The configs have never been used (sys_mbox_new() silently ignores them), so I doubt this is a breaking change and did not mark it as such.
Fixes #12046

Impact of changes

Some mbed_app.json files may not compile if they used the removed options.

Documentation

Not required


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pstolarz
@kjbracey-arm
@AnttiKauppila


The configs have never been used and LWIP just uses its own settings.
@mbed-ci
Copy link

mbed-ci commented Dec 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

@michalpasztamobica I've updated the template for you to show how the description should be added. These fields will be automatically parsed in the future so it would be helpful if you could use the template as designed. Many thanks .

@adbridge adbridge merged commit c519967 into ARMmbed:master Dec 19, 2019
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed ready for merge labels Dec 19, 2019
@michalpasztamobica michalpasztamobica deleted the lwip_remove_unused_mbox_configs branch December 20, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWIP mailbox size configuration
5 participants