Cellular: Suppress long AT traces #12133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kivaisan, thank you for your changes. |
AriParkkila
approved these changes
Dec 19, 2019
AnttiKauppila
approved these changes
Dec 19, 2019
When AT traces are enabled and very long AT commands are traced, system can easily go to unwanted state. Therefore the length of the AT traces is limited to DEBUG_MAXLEN (currently 60 characters). This commit fixes read_hex_string, read_bytes and write to use this limitter.
|
I added perfomance impact note to help of |
kjbracey
approved these changes
Dec 19, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When AT traces are enabled and very long AT commands are traced,
system can easily go to unwanted state. Therefore the length of the AT
traces is limited to DEBUG_MAXLEN (currently 60 characters).
This commit fixes read_hex_string, read_bytes and write to use this
limitter.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan