Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM serial init: Set pin function only if pin is defined (not NC) #12186

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Jan 3, 2020

Summary of changes

This is patch for issue #12172.

During serial initialization set pin function only if the pin is specified (not NC).

Verified that the following code works with the patch:

main()
{
 Serial tx_only_serial(PE_8, NC); // halts here
 tx_only_serial.putc('A');
}

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170 0xc0170 requested a review from a team January 3, 2020 13:19
@mbed-ci
Copy link

mbed-ci commented Jan 3, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

Looks like that failure may have been a device issue in the ci. Restarting.

@mbed-ci
Copy link

mbed-ci commented Jan 6, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

@mprse There are IOERR_SERIAL for one disco board, are these related?

@mprse
Copy link
Contributor Author

mprse commented Jan 7, 2020

I saw the results. Tried to reproduce this locally, but without success. Have you seen such failures before? This PR changes the STM UART driver a bit, but not sure if these failures are related.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

Restarted the tests. I haven't seen ioserial today but the target previously had sometimes serial issue (if this is confirmed, we should check what board is it, might need hardware restart).

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: work needs: CI labels Jan 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

It was just a target serial error. I'll monitor the next tests after this integration just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants