-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM serial init: Set pin function only if pin is defined (not NC) #12186
Conversation
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Looks like that failure may have been a device issue in the ci. Restarting. |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
@mprse There are |
I saw the results. Tried to reproduce this locally, but without success. Have you seen such failures before? This PR changes the STM UART driver a bit, but not sure if these failures are related. |
Restarted the tests. I haven't seen ioserial today but the target previously had sometimes serial issue (if this is confirmed, we should check what board is it, might need hardware restart). |
It was just a target serial error. I'll monitor the next tests after this integration just in case. |
Summary of changes
This is patch for issue #12172.
During serial initialization set pin function only if the pin is specified (not NC).
Verified that the following code works with the patch:
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers