Cellular: Move cellular event queue thread ownership to CellularDevice #12193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier CellularDevice has owned event queue used by cellular (state machine and ATHandler for example), but the thread used to dispatch the queue has been owned by state machine. This commit moves the event queue thread to CellularDevice so now the ownership of cellular event queue is in one place.
|
@kivaisan, thank you for your changes. |
AnttiKauppila
approved these changes
Jan 7, 2020
AriParkkila
approved these changes
Jan 7, 2020
0xc0170
approved these changes
Jan 7, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Client test restarted |
0xc0170
added
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Earlier CellularDevice has owned the event queue used by cellular (state machine and ATHandler for example), but the thread used to dispatch the queue has been owned by state machine.
This commit moves the event queue thread to CellularDevice so now the ownership of cellular event queue is in one place.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan