Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Add DEVICE_USBDEVICE detection in usbd implementation #12217

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

This PR is to fix issue #12212 . To add DEVICE_USBDEVICE detection to let: usbd implementation code will be only included as while DEVICE_USBDEVICE is enabled.

Migration actions required


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Build log of M252KG ( DEVICE_USBDEVICE not enable ) :

[mbed-os-example-blinky]$ mbed compile -m NUMAKER_M252KG -t ARM
Building project mbed-os-example-blinky (NUMAKER_M252KG, ARMC6)
Scan: mbed-os-example-blinky
Compile [  0.1%]: mbed_tz_context.c
.........................................................
Elf2Bin: mbed-os-example-blinky
| Module           |     .text |   .data |      .bss |
|------------------|-----------|---------|-----------|
| [lib]\c_p.l      | 10995(+0) |  16(+0) |   348(+0) |
| [lib]\fz_ps.l    |   618(+0) |   0(+0) |     0(+0) |
| [lib]\m_ps.l     |    44(+0) |   0(+0) |     0(+0) |
| anon$$obj.o      |    32(+0) |   0(+0) | 24960(+0) |
| main.o           |   355(+0) |   0(+0) |    36(+0) |
| mbed-os\drivers  |    78(+0) |   0(+0) |     0(+0) |
| mbed-os\features |   141(+0) |   0(+0) |     0(+0) |
| mbed-os\hal      |  1988(+0) |   4(+0) |    67(+0) |
| mbed-os\platform |  4094(+0) |  64(+0) |   224(+0) |
| mbed-os\rtos     |  8773(+0) | 168(+0) |  6626(+0) |
| mbed-os\targets  |  5654(+0) |  96(+0) |   127(+0) |
| Subtotals        | 32772(+0) | 348(+0) | 32388(+0) |
Total Static RAM memory (data + bss): 32736(+0) bytes
Total Flash memory (text + data): 33120(+0) bytes

Image: .\BUILD\NUMAKER_M252KG\ARM\mbed-os-example-blinky.bin
[mbed] Working path "C:\ARM_mbed\examples\mbed-os-example-blinky" (program)


Build log of NUC472 ( DEVICE_USBDEVICE enable ) :

[~mbed-test]$ mbed test -m NUMAKER_PFM_NUC472 -t ARM -n mbed-os-tests-usb_device-* --compile
Building library mbed-build (NUMAKER_PFM_NUC472, ARMC6)
.......................................
Image: BUILD/tests/NUMAKER_PFM_NUC472/ARM/mbed-os/TESTS/usb_device/hid/hid.bin


Memory map breakdown for built projects (values in Bytes):
| name   | target             | toolchain | static_ram | total_flash |
|--------|--------------------|-----------|------------|-------------|
| basic  | NUMAKER_PFM_NUC472 | ARMC6     |    1062379 |       70176 |
| hid    | NUMAKER_PFM_NUC472 | ARMC6     |    1059642 |       67953 |
| msd    | NUMAKER_PFM_NUC472 | ARMC6     |    1060635 |       94461 |
| serial | NUMAKER_PFM_NUC472 | ARMC6     |    1060246 |       82224 |


Build successes:
  * NUMAKER_PFM_NUC472::ARMC6::MBED-BUILD
  * NUMAKER_PFM_NUC472::ARMC6::MBED-OS-TESTS-USB_DEVICE-BASIC
  * NUMAKER_PFM_NUC472::ARMC6::MBED-OS-TESTS-USB_DEVICE-HID
  * NUMAKER_PFM_NUC472::ARMC6::MBED-OS-TESTS-USB_DEVICE-MSD
  * NUMAKER_PFM_NUC472::ARMC6::MBED-OS-TESTS-USB_DEVICE-SERIAL
[mbed] Working path "C:\ARM_mbed\examples\mbed-test" (program)


Reviewers

@0xc0170 , @MarceloSalazar

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2020

cloud-client-test restarted

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 8, 2020
@0xc0170 0xc0170 merged commit 40b7901 into ARMmbed:master Jan 8, 2020
@cyliangtw cyliangtw deleted the nuvoton_usbd branch March 9, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants