-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: Remove friend definitions from cellular state machine #12251
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
kivaisan:remove_friends_from_statemachine
Feb 5, 2020
Merged
Cellular: Remove friend definitions from cellular state machine #12251
0xc0170
merged 1 commit into
ARMmbed:master
from
kivaisan:remove_friends_from_statemachine
Feb 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of defining which classes can access state machine, CellularStateMachine class is now "a normal" CPP class with public API.
AriParkkila
approved these changes
Jan 14, 2020
0xc0170
approved these changes
Jan 14, 2020
mirelachirica
approved these changes
Jan 15, 2020
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@AnttiKauppila Please review. This will be marked as ready for merge once approved. |
NOTE the ci last ran several days ago and thus this will need to be run again before it can be merged, to ensure no conflicts etc due to other merges in the interim! |
CI restarted |
AnttiKauppila
approved these changes
Feb 5, 2020
0xc0170
added
the
release-version: 6.0.0-alpha-2
Second pre-release version of 6.0.0
label
Feb 5, 2020
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Instead of defining which classes can access state machine,
CellularStateMachine
class is now "a normal" CPP class with public API.
Impact of changes
This is potentially a breaking change but as
CellularStateMachine
is only used internally there shouldn't be any impact.Migration actions required
None, internal change
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan