Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Remove friend definitions from cellular state machine #12251

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Cellular: Remove friend definitions from cellular state machine #12251

merged 1 commit into from
Feb 5, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Jan 14, 2020

Summary of changes

Instead of defining which classes can access state machine, CellularStateMachine
class is now "a normal" CPP class with public API.

Impact of changes

This is potentially a breaking change but as CellularStateMachine is only used internally there shouldn't be any impact.

Migration actions required

None, internal change

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan


Instead of defining which classes can access state machine, CellularStateMachine
class is now "a normal" CPP class with public API.
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2020

@AnttiKauppila Please review. This will be marked as ready for merge once approved.

@adbridge
Copy link
Contributor

NOTE the ci last ran several days ago and thus this will need to be run again before it can be merged, to ensure no conflicts etc due to other merges in the interim!

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2020

CI restarted

@mergify mergify bot added needs: CI and removed needs: review labels Feb 5, 2020
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 5, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 5, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 9686110 into ARMmbed:master Feb 5, 2020
@mergify mergify bot removed the ready for merge label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING-CHANGE release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants