STM32 FLASH API : add critical sections #13914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeanMarcR, thank you for your changes. |
jeromecoutant
suggested changes
Nov 17, 2020
| /* Note: If an erase operation in Flash memory also concerns data in the data or instruction cache, | ||
| you have to make sure that these data are rewritten before they are accessed during code | ||
| execution. If this cannot be done safely, it is recommended to flush the caches by setting the | ||
| DCRST and ICRST bits in the FLASH_CR register. */ | ||
| __HAL_FLASH_ART_DISABLE(); | ||
| __HAL_FLASH_ART_RESET(); | ||
| __HAL_FLASH_ART_RESET();q |
| flash_lock(); | ||
| core_util_critical_section_exit(); | ||
|
|
||
| HAL_FLASH_Lock(); |
There was a problem hiding this comment.
I would prefer to align code with HAL_FLASH_Unlock call:
if (HAL_FLASH_Lock() != HAL_OK) {
return -1;
}
?
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
jeromecoutant
approved these changes
Nov 19, 2020
|
@JeanMarcR Travis job has failed, I think you have to rebase on top of master |
See PR ARMmbed#13802 (for F4 board) Concerned boards are STM32F0 STM32F1 STM32F2 STM32F3 STM32F4 STM32F7 STM32G0 STM32G4 STM32H7 STM32L0 STM32L1 STM32L4 STM32L5 Adding test of return code of HAL_FLASH_Lock() function Adding board STM32F4 Running AStyle
|
@jeromecoutant |
|
@jeromecoutant |
0xc0170
approved these changes
Nov 23, 2020
jeromecoutant
approved these changes
Nov 23, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
@jeromecoutant |
0xc0170
added
the
release-type: patch
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #13802 (for F4 board)
Concerned boards are
STM32F0
STM32F1
STM32F2
STM32F3
STM32F7
STM32G0
STM32G4
STM32H7
STM32L0
STM32L1
STM32L4
STM32L5
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers