Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: add all TARGET_STM targets #13915

Merged
merged 19 commits into from
Nov 24, 2020
Merged

CMake: add all TARGET_STM targets #13915

merged 19 commits into from
Nov 24, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 17, 2020

Summary of changes

Adding CMakeLists.txt to all STM targets.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba @rajkan01

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 17, 2020
@ciarmcom ciarmcom requested review from hugueskamba, rajkan01 and a team November 17, 2020 17:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@rajkan01 @hugueskamba @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

jeromecoutant
jeromecoutant approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (not tested).
Good to see that impact is not so important.
IAR is definitively abandoned ?

ladislas
ladislas approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! :)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 18, 2020 •
edited
Loading

IAR is definitively abandoned ?

I did not port IAR as it is currently not supported neither with our CMake.

hugueskamba
hugueskamba previously approved these changes Nov 18, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Nov 18, 2020
@hugueskamba
Copy link
Collaborator

Please update the README file to indicate that all ST targets are supported.

@mergify mergify bot dismissed hugueskamba’s stale review November 18, 2020 12:14

Pull request has been modified.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 18, 2020

Readme updated. I also fixed few issues found while locally testing. I was able to compile couple of different STM32 targets.

hugueskamba
hugueskamba reviewed Nov 18, 2020
View reviewed changes
tools/cmake/README.md
@@ -19,12 +19,10 @@ The full profile with the selected printf and C libraries.
Only a limited set of targets is supported at the moment.

The following targets are supported:
- DISCO_L475VG_IOT01A
- all STM32 targets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- all STM32 targets
- All STM32 Mbed targets

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not...?
We are working to ease the support for all custom boards with STM32. I hope that cmake feature keeps this goal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not count here custom targets. we ported all targets in the tree, or not?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but STM32 targets that are not in mbed yet support cmake structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will assist initially porting new targets, so any new PR labeled as "new target" will need to add CMake as well. I'll review opened PR and address this there.

We are going to share the porting guide in the following days.

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 mentioned this pull request Nov 23, 2020
Merged
facchinm added a commit to arduino/mbed-os that referenced this pull request Nov 23, 2020
@facchinm
[Portenta] Add Cmake rules
441aae2 
Completes ARMmbed#13915
@0xc0170 0xc0170 merged commit a1fc9cd into ARMmbed:master Nov 24, 2020
@0xc0170 0xc0170 deleted the cmake-stm32 branch November 24, 2020 14:09
@mergify mergify bot removed the ready for merge label Nov 24, 2020
facchinm added a commit to arduino/mbed-os that referenced this pull request Nov 24, 2020
@facchinm
[Portenta] Add Cmake rules
b426fc0 
Completes ARMmbed#13915
facchinm added a commit to arduino/mbed-os that referenced this pull request Dec 3, 2020
@facchinm
[Portenta] Add Cmake rules
9c8405a 
Completes ARMmbed#13915
facchinm added a commit to arduino/mbed-os that referenced this pull request Dec 10, 2020
@facchinm
[Portenta] Add Cmake rules
4811ce6 
Completes ARMmbed#13915
facchinm added a commit to arduino/mbed-os that referenced this pull request Dec 10, 2020
@facchinm
[Portenta] Add Cmake rules
a976aed 
Completes ARMmbed#13915
facchinm added a commit to arduino/mbed-os that referenced this pull request Dec 11, 2020
@facchinm
[Portenta] Add Cmake rules
a7a6f2a 
Completes ARMmbed#13915
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba left review comments

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@ladislas ladislas ladislas approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@0xc0170 @ciarmcom @hugueskamba @mbed-ci @ladislas @jeromecoutant @mbedmain