Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Add support for all NXP Mbed targets #13924

Merged
merged 7 commits into from
Dec 10, 2020
Merged

CMake: Add support for all NXP Mbed targets #13924

merged 7 commits into from
Dec 10, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Add CMakeLists.txt so all NXP Mbed targets can be built with CMake.

Impact of changes

Migration actions required

Documentation

https://github.com/ARMmbed/mbed-os/blob/master/tools/cmake/README.md

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba force-pushed the hk_cmake_port_nxp_targets branch 2 times, most recently from df18a80 to 4d28deb Compare November 18, 2020 18:40
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 18, 2020
@ciarmcom ciarmcom requested review from a team November 18, 2020 19:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/team-nxp @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one styling question, otherwise +1

targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC54114/CMakeLists.txt Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

There are couple of set_property left still otherwise LGTM

@hugueskamba
Copy link
Collaborator Author

There are couple of set_property left still otherwise LGTM

They have all been changed now.

@mergify
Copy link

mergify bot commented Nov 26, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify
Copy link

mergify bot commented Nov 27, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

0xc0170
0xc0170 previously approved these changes Nov 30, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Nov 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2020

CI started

@mergify mergify bot added the needs: work label Nov 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 3, 2020
@mergify
Copy link

mergify bot commented Dec 7, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

I'll rebase once another CMake PR is in.

@hugueskamba @0xc0170
CMake: Fix GCC_ARM Cortex-M0 support
229b9ad 
Add missing toolchain option to specify the CPU core
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

Fixes to common files should be in separate PRs, I am going through rebase with multiple files now. I'll fix them and restart CI

@hugueskamba @0xc0170
CMake: Add support for LPC11XX_11CXX targets
4acc57c 
All LPC11XX_11CXX targets supported by Mbed OS
can now be built with CMake.
@hugueskamba @0xc0170
CMake: Fix GCC_ARM Cortex-M3 support
59da1e9 
Add missing toolchain option to specify the CPU core
@hugueskamba @0xc0170
CMake: Add support for LPC176X targets
72d0fb9 
All LPC176X targets supported by Mbed OS
can now be built with CMake.
@hugueskamba @0xc0170
CMake: Fix GCC_ARM Cortex-M33 and Cortex-M33-NS support
ea6661c 
Add missing toolchain option to specify the CPU core
@hugueskamba @0xc0170
CMake: Add support for TARGET_MCUXpresso_MCUS targets
cf23ba5 
All TARGET_MCUXpresso_MCUS targets supported by Mbed OS
can now be built with CMake.
@hugueskamba @0xc0170
CMake: List NXP targets as supported in README
743563c
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 9adc355 into ARMmbed:master Dec 10, 2020
@mergify mergify bot removed the ready for merge label Dec 10, 2020
@hugueskamba hugueskamba deleted the hk_cmake_port_nxp_targets branch December 11, 2020 10:00
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mbedmain