Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L4 : align CMakeLists.txt with all STM32 #14293

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

@0xc0170

2 families have a different cmake implementation.

Goal is to align all

Thx

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 16, 2021
@ciarmcom ciarmcom requested a review from a team February 16, 2021 17:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@jeromecoutant
Copy link
Collaborator Author

@0xc0170

@jeromecoutant
Copy link
Collaborator Author

Part of #14339 now

@jeromecoutant jeromecoutant deleted the PR_CMAKE_ALIGN branch February 24, 2021 11:17
@mergify mergify bot removed devices: st needs: review release-type: patch Indentifies a PR as containing just a patch stale Stale Pull Request labels Feb 24, 2021
@jeromecoutant jeromecoutant restored the PR_CMAKE_ALIGN branch February 24, 2021 11:19
@jeromecoutant jeromecoutant reopened this Feb 24, 2021
@jeromecoutant
Copy link
Collaborator Author

Keep STM32L4 part in this PR

@jeromecoutant jeromecoutant changed the title STM32L4/STM32F4 : align CMakeLists.txt with all STM32 STM32L4 : align CMakeLists.txt with all STM32 Feb 24, 2021
@jeromecoutant
Copy link
Collaborator Author

@0xc0170 ping

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2021

CI started

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Mar 9, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 5326e30 into ARMmbed:master Mar 11, 2021
@mergify mergify bot removed the ready for merge label Mar 11, 2021
@jeromecoutant jeromecoutant deleted the PR_CMAKE_ALIGN branch March 11, 2021 08:58
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants