Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix ARM MUSCA NS targets build #14314

Merged
merged 1 commit into from
Feb 23, 2021
Merged

CMake: Fix ARM MUSCA NS targets build #14314

merged 1 commit into from
Feb 23, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Add the missing CMake targets for NS Mbed boards.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
CMake: Fix ARM MUSCA NS targets build
0ce36ac 
Add the missing CMake targets for NS Mbed boards.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 22, 2021
@ciarmcom ciarmcom requested a review from a team February 22, 2021 12:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 22, 2021
@mergify mergify bot added needs: work and removed needs: CI labels Feb 22, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 57a6fe3 into ARMmbed:master Feb 23, 2021
@mergify mergify bot removed the ready for merge label Feb 23, 2021
@hugueskamba hugueskamba deleted the hk_cmake_fix_musca_ns branch February 23, 2021 11:31
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@Patater Patater Patater approved these changes

@saheerb saheerb Awaiting requested review from saheerb

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
devices: arm release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @Patater @LDong-Arm @mbedmain