Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSOC6: Catch possible error in post build script #14324

Merged
merged 1 commit into from
Mar 2, 2021
Merged

PSOC6: Catch possible error in post build script #14324

merged 1 commit into from
Mar 2, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Fixes #14317

Raise an exception in case of a failure to find an image to use for the binary signature. This prevents the method from assuming the image is always successfully retrieved and crash when attempting to print a message.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
PSOC6: Fix post build script
a8b9d49 
Raise an exception in case of a failure to find an image to use
for the binary signature. This prevents the method from assuming
the image is always successfully retrieved and crash when
attempting to print a message
@hugueskamba hugueskamba requested review from a team, 0xc0170 and Patater February 22, 2021 17:15
@ciarmcom ciarmcom requested a review from a team February 22, 2021 17:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/team-cypress @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 23, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Feb 25, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 1, 2021

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 1, 2021

@ARMmbed/team-cypress Please review

@LDong-Arm
Copy link
Contributor

Note that the reported issue was fixed by #14344 (merged). This PR is a nice-to-have error catching but not affecting functionality right now.

@hugueskamba hugueskamba changed the title PSOC6: Fix post build script PSOC6: Catch possible error in post build script Mar 1, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 44e9e3c into ARMmbed:master Mar 2, 2021
@mergify mergify bot removed the ready for merge label Mar 2, 2021
@mergify
Copy link

mergify bot commented Mar 2, 2021

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Mar 2, 2021
@hugueskamba hugueskamba deleted the hk_fix_psoc6_post_build_script branch March 2, 2021 12:35
@0xc0170 0xc0170 removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards stale Stale Pull Request labels Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@Patater Patater Awaiting requested review from Patater

@ifyall ifyall Awaiting requested review from ifyall

@LDong-Arm LDong-Arm Awaiting requested review from LDong-Arm

@RaymondNgun RaymondNgun Awaiting requested review from RaymondNgun

Assignees
No one assigned
Labels
devices: cypress release-version: 6.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CYTFM_064B0S2_4343W: Fails to complete post build operation
5 participants
@hugueskamba @ciarmcom @0xc0170 @LDong-Arm @mbed-ci