EP Atlas Target Updates #14325

AGlass0fMilk · 2021-02-22T20:47:45Z

Summary of changes

This PR introduces several updates to the EP_ATLAS target.

Namely, the updates are:

Introduce `subtarget_sdk_init` startup hook.

The mbed_sdk_init startup hook is implemented at the NRF52-series level and so is unavailable for override. This commit adds an additional startup hook for NRF52 subtargets to perform any other startup initialization required.

Configure internal regulators at startup

This commit introduces an implementation of the subtarget_sdk_init startup hook (called during mbed_sdk_init) that configures the internal regulators of the nRF52840.

The configuration sets up the internal regulator to output 3.3V. If this is not done, the default system voltage may be too low for the on-board indicator LEDs to conduct (ie: system voltage is lower than LED forward voltage).

Add option to use USBSerial for stdio console

This commit introduces an option, ep-atlas.enable-usb-stdio-console, that will retarget the Mbed stdio console handle to a USBSerial instance if enabled.

Please note that if your application uses USB, it will conflict with this option. You should disable this option and implement a composite USB device in your application if you require stdio over USB.

This option is disabled by default so it will not cause issues with existing user code.

Add default app start and size limitations

This commit introduces a default application start address (0x1000) and size limitation (0xDF000) to accomodate the Nordic USB bootloader.

The bootloader consists of a master boot record in flash from address 0x0 to 0x1000 and the actual bootloader application starting at 0xE0000 to the end of flash (0x100000). The bootloader enables firmware updates over USB using nRF Connect for Desktop.

More documentation regarding the open bootloader can be found here: https://infocenter.nordicsemi.com/topic/sdk_nrf5_v17.0.2/ble_sdk_app_open_bootloader.html

Impact of changes

The USB stdio console option is disabled by default and so will not have any impact on existing code.

The regulator initialization at startup will fix issues with on-board LED indicators not lighting up due to the system voltage being set too low. Previously, users would have to execute this configuration from their own main function. This configuration is now implemented as part of the target's initialization code.

Migration actions required

Remove regulator initialization from user application, if required.

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@farrenv @trowbridgec

ciarmcom · 2021-02-22T21:00:22Z

@AGlass0fMilk, thank you for your changes.
@trowbridgec @farrenv @ARMmbed/mbed-os-maintainers please review.

AGlass0fMilk · 2021-02-22T23:10:54Z

Tested and building blinky/printf over USB on Atlas 👍

0xc0170

Otherwise LGTM

...ets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_ATLAS/atlas_init.c

The `mbed_sdk_init` startup hook is implemented at the NRF52-series level and so is unavailable for override. This commit adds an additional startup hook for NRF52 subtargets to perform any other startup initialization required.

This commit introduces an implementation of the `subtarget_sdk_init` startup hook (called during `mbed_sdk_init`) that configures the internal regulators of the nRF52840. The configuration sets up the internal regulator to output 3.3V. If this is not done, the default system voltage may be too low for the on-board indicator LEDs to conduct (ie: system voltage is lower than LED forward voltage).

This commit introduces an option, `ep-atlas.enable-usb-stdio-console`, that will retarget the Mbed stdio console handle to a USBSerial instance if enabled. Please note that if your application uses USB, it will conflict with this option. You should disable this option and implement a composite USB device in your application if you require stdio over USB. This option is disabled by default so it will not cause issues with existing user code.

This commit introduces a default application start address (`0x1000`) and size limitation (`0xDF000`) to accomodate the Nordic USB bootloader. The bootloader consists of a master boot record in flash from address `0x0` to `0x1000` and the actual bootloader application starting at `0xE0000` to the end of flash (`0x100000`). The bootloader enables firmware updates over USB using nRF Connect for Desktop. More documentation regarding the open bootloader can be found here: https://infocenter.nordicsemi.com/topic/sdk_nrf5_v17.0.2/ble_sdk_app_open_bootloader.html

AGlass0fMilk · 2021-02-23T15:04:13Z

Otherwise LGTM

Alignment issue has been resolved.

0xc0170 · 2021-02-23T20:14:38Z

...ts/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_ATLAS/usb_stdio.cpp

+#if MBED_CONF_EP_ATLAS_ENABLE_USB_STDIO_CONSOLE
+
+/* Retarget stdio to USBSerial */
+mbed::FileHandle *mbed::mbed_target_override_console(int fd) {


can you run astyle on these new files?

Ran astyle -n --options=.astylerc on the new files and pushed up changes.

Pull request has been modified.

0xc0170 · 2021-02-23T20:51:19Z

Thanks for the fixes. Can you attach testing logs for both toolchains?

AGlass0fMilk · 2021-02-24T15:35:57Z

Thanks for the fixes. Can you attach testing logs for both toolchains?

This target is a bit abnormal. It does not have an on-board debugger. It works more like an nRF52840 dongle. The board is programmed with a bootloader that lets you update it over USB using the nRF Connect software.

I'm not sure if Mbed's automated testing tools would support flashing/testing this target...

It's mostly based on the nRF52840_DK so think that is sufficient. There are only some small changes (like this PR) to accommodate the bootloader and hardware regulator configuration.

0xc0170 · 2021-02-25T13:25:32Z

CI started

mbed-ci · 2021-02-25T14:17:32Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	❌

AGlass0fMilk · 2021-02-25T14:50:37Z

I think I need to add the new files to cmake... will have to learn the new tools.

0xc0170 · 2021-02-25T14:56:30Z

Please do. It should be fairly simple , if any questions, I can assist.

AGlass0fMilk · 2021-02-25T15:35:19Z

@0xc0170 How does that look? 🙂 d00699c

Pull request has been modified.

0xc0170 · 2021-02-25T15:40:46Z

targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/CMakeLists.txt

@@ -25,6 +25,13 @@ target_include_directories(mbed-ep-atlas
        TARGET_EP_ATLAS
 )

+target_sources(mbed-ep-atlas


you need to create the library add_library(mbed-ep-atlas INTERFACE) and possibly later here to link it with nrf52xx library to get common drivers,sdks, etc.

dk board should do that below

Ah wait, it's not visible in my view, but I can see it already there

ciarmcom · 2021-02-27T16:50:30Z

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

0xc0170 · 2021-03-01T12:45:45Z

CI restarted

mbed-ci · 2021-03-01T17:17:10Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 22, 2021

ciarmcom requested review from farrenv, trowbridgec and a team February 22, 2021 21:00

ciarmcom added needs: review devices: nordic labels Feb 22, 2021

AGlass0fMilk changed the title ~~EP Atlas Target Updates - Regulator configuration and USB stdio~~ [WIP] EP Atlas Target Updates - Regulator configuration and USB stdio Feb 22, 2021

AGlass0fMilk changed the title ~~[WIP] EP Atlas Target Updates - Regulator configuration and USB stdio~~ [WIP] EP Atlas Target Updates - Regulator configuration, USB stdio, application start address and size Feb 22, 2021

AGlass0fMilk force-pushed the ep-atlas-reg-init branch from 965907e to 7ae55cb Compare February 22, 2021 22:41

AGlass0fMilk changed the title ~~[WIP] EP Atlas Target Updates - Regulator configuration, USB stdio, application start address and size~~ EP Atlas Target Updates Feb 22, 2021

AGlass0fMilk force-pushed the ep-atlas-reg-init branch from 7ae55cb to 1cb2ae9 Compare February 22, 2021 23:15

0xc0170 added the scope: new-target label Feb 23, 2021

0xc0170 reviewed Feb 23, 2021

View reviewed changes

...ets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_ATLAS/atlas_init.c Outdated Show resolved Hide resolved

AGlass0fMilk force-pushed the ep-atlas-reg-init branch 2 times, most recently from 1fc52b8 to d58ee83 Compare February 23, 2021 15:03

AGlass0fMilk added 4 commits February 23, 2021 10:03

Introduce subtarget_sdk_init startup hook.

9e4d462

The `mbed_sdk_init` startup hook is implemented at the NRF52-series level and so is unavailable for override. This commit adds an additional startup hook for NRF52 subtargets to perform any other startup initialization required.

AGlass0fMilk force-pushed the ep-atlas-reg-init branch from d58ee83 to b6478ba Compare February 23, 2021 15:03

0xc0170 previously requested changes Feb 23, 2021

View reviewed changes

mergify bot added needs: work and removed needs: review labels Feb 23, 2021

Fix astyle issues

0212fde

AGlass0fMilk force-pushed the ep-atlas-reg-init branch from b6478ba to 0212fde Compare February 23, 2021 20:44

0xc0170 previously approved these changes Feb 23, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Feb 23, 2021

mergify bot added needs: work and removed needs: CI labels Feb 25, 2021

Add subtarget_init files to cmake

d00699c

0xc0170 reviewed Feb 25, 2021

View reviewed changes

0xc0170 approved these changes Feb 25, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: work labels Feb 25, 2021

ciarmcom added the stale Stale Pull Request label Feb 27, 2021

mergify bot added ready for merge and removed needs: CI labels Mar 1, 2021

0xc0170 removed the scope: new-target label Mar 2, 2021

0xc0170 merged commit f78c241 into ARMmbed:master Mar 2, 2021

mergify bot removed the ready for merge label Mar 2, 2021

mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EP Atlas Target Updates #14325

EP Atlas Target Updates #14325

AGlass0fMilk commented Feb 22, 2021 •

edited

Loading

ciarmcom commented Feb 22, 2021

AGlass0fMilk commented Feb 22, 2021

0xc0170 left a comment

AGlass0fMilk commented Feb 23, 2021

0xc0170 Feb 23, 2021

AGlass0fMilk Feb 23, 2021

0xc0170 commented Feb 23, 2021

AGlass0fMilk commented Feb 24, 2021 •

edited

Loading

0xc0170 commented Feb 25, 2021

mbed-ci commented Feb 25, 2021

AGlass0fMilk commented Feb 25, 2021

0xc0170 commented Feb 25, 2021

AGlass0fMilk commented Feb 25, 2021

0xc0170 Feb 25, 2021 •

edited

Loading

0xc0170 Feb 25, 2021

ciarmcom commented Feb 27, 2021

0xc0170 commented Mar 1, 2021

mbed-ci commented Mar 1, 2021

EP Atlas Target Updates #14325

EP Atlas Target Updates #14325

Conversation

AGlass0fMilk commented Feb 22, 2021 • edited Loading

Summary of changes

Introduce subtarget_sdk_init startup hook.

Configure internal regulators at startup

Add option to use USBSerial for stdio console

Add default app start and size limitations

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

ciarmcom commented Feb 22, 2021

AGlass0fMilk commented Feb 22, 2021

0xc0170 left a comment

Choose a reason for hiding this comment

AGlass0fMilk commented Feb 23, 2021

0xc0170 Feb 23, 2021

Choose a reason for hiding this comment

AGlass0fMilk Feb 23, 2021

Choose a reason for hiding this comment

0xc0170 commented Feb 23, 2021

AGlass0fMilk commented Feb 24, 2021 • edited Loading

0xc0170 commented Feb 25, 2021

mbed-ci commented Feb 25, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

AGlass0fMilk commented Feb 25, 2021

0xc0170 commented Feb 25, 2021

AGlass0fMilk commented Feb 25, 2021

0xc0170 Feb 25, 2021 • edited Loading

Choose a reason for hiding this comment

0xc0170 Feb 25, 2021

Choose a reason for hiding this comment

ciarmcom commented Feb 27, 2021

0xc0170 commented Mar 1, 2021

mbed-ci commented Mar 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

AGlass0fMilk commented Feb 22, 2021 •

edited

Loading

Introduce `subtarget_sdk_init` startup hook.

AGlass0fMilk commented Feb 24, 2021 •

edited

Loading

0xc0170 Feb 25, 2021 •

edited

Loading