STM32 - Add if !defined check for USE_HAL_XXX_REGISTER_CALLBACKS #14351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@ladislas, thank you for your changes. |
jeromecoutant
approved these changes
Feb 25, 2021
0xc0170
previously approved these changes
Feb 25, 2021
ladislas
force-pushed
the
ladislas/stm32f7/use_callbacks
branch
from
23fd3a5
to
143176b
Compare
mergify
bot
dismissed
0xc0170’s stale review
Pull request has been modified.
@jeromcoutant -- no patch, just Ctrl/Cmd + D, Ctrl/Cmd + C/V and a few keystrokes. I'll do them all and push there |
|
@jeromecoutant and voila! |
ladislas
changed the title
|
@ladislas, thank you for your changes. |
|
This pull request has automatically been marked as stale because it has had no recent activity. @0xc0170, please complete review of the changes to move the PR forward. Thank you for your contributions. |
|
@0xc0170 Could we start CI? :) |
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 6, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
0xc0170
approved these changes
Mar 8, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 9, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 9, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 15, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 16, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
mbedmain
removed
release-type: patch
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 30, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 30, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Mar 30, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Apr 1, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
ladislas
added a commit
to leka/LekaOS
that referenced
this pull request
Apr 2, 2021
This commit is a workaround to correctly defined USE_HAL_JPEG_REGISTER_CALLBACKS while we wait for > ARMmbed/mbed-os#14351 to be merge into master. The commit can be dropped if 14351 is merged before feature/images_and_animations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The following PR adds
#if !definedchecks forUSE_HAL_XXX_REGISTER_CALLBACKSon STM32F7.Impact of changes
Allows users to register HAL callbacks.
Migration actions required
None
Documentation
None, this is very advanced use case.
Pull request type
Test results
Reviewers
@jeromecoutant