CMake: support signing TF-M targets with post binary hooks #14361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
changed the title
ciarmcom
requested review from
0xc0170,
evedon,
hugueskamba,
rajkan01 and
a team
|
@LDong-Arm, thank you for your changes. |
0xc0170
reviewed
Mar 2, 2021
hugueskamba
reviewed
Mar 2, 2021
LDong-Arm
force-pushed
the
musca_post_binary_hooks
branch
from
7b13ca4
to
38100aa
Compare
LDong-Arm
commented
Mar 2, 2021
...ERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_LATEST/scripts/mbed_set_post_build_tfm.cmake
Outdated
Show resolved
Hide resolved
LDong-Arm
force-pushed
the
musca_post_binary_hooks
branch
from
38100aa
to
96239bb
Compare
hugueskamba
approved these changes
Mar 4, 2021
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
The signing keys were previously imported from trusted-firmware-m and located in mbed-os/tools/targets/musca_* (path for Mbed CLI 1). This PR copie them into each target's directory as per the convention of the new tools. Keys in the old path remain untouched for backward compatibility, but they will be eventually removed once we stop supporting Mbed CLI 1.
This commit adds post binary hook support for TF-M targets.
To apply this hook to a TF-M target, do the following in the target's
`CMakeLists.txt`:
* include `mbed_set_post_build_tfm.cmake`
* call `mbed_post_build_tfm_sign_image()`, passing
- Mbed OS target name
- TF-M target name
- path containing the target's bootloader, layout files and signing
keys
- path to the secure binary
- path to the non-secure binary (i.e. the "raw" Mbed application)
LDong-Arm
force-pushed
the
musca_post_binary_hooks
branch
from
96239bb
to
3e19778
Compare
|
Rebased after the merging of the preceding PR. Now looking into the failed test in CI. |
|
It's a CI issue. "jenkins-ci/mbed-os-ci_tfm-integration" is a brand new pipeline that never ran before, we need to fix the pipeline. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Mar 8, 2021
mbedmain
added
release-version: 6.9.0
Release-pending
and removed
release-type: feature
Release-pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Preceding PR: #14378 (merged)
Changes:
mbed_post_build_tfm_sign_image()(should work for any TF-M v1.2+ targets with secure and non-secure images in separate MCUboot slots). This was refactored from the existingtools/targets/ARM_MUSCA.py.Impact of changes
Images built for Musca B1 and S1 with Mbed CLI 2 are now signed and able to run on the targets.
Migration actions required
None.
Documentation
To be added to the porting guide: how to integrate CMake and the provided post binary hook to a new TF-M target.
Pull request type
Test results
Reviewers
@evedon @0xc0170 @hugueskamba @rajkan01 @ARMmbed/mbed-b-tools