EP_ATLAS: Fix mbedtools build errors #14418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
ciarmcom
requested review from
0xc0170,
MarceloSalazar,
pan-,
Patater and
a team
|
@hugueskamba, thank you for your changes. |
|
@ARMmbed/team-embeddedplanet |
0xc0170
reviewed
Mar 11, 2021
...ts/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/TARGET_EP_ATLAS/usb_stdio.cpp
Show resolved
Hide resolved
Patater
reviewed
Mar 11, 2021
Enable Onboard TELIT ME310 driver only when cellular library is included. This allows us to remove the cellular library as a requirement to build applications that do not require it (i.e Blinky).
Move inclusion of USB header file within the existing conditional pre-processor directive so the USB library is not required if USB stdio console is disable
hugueskamba
force-pushed
the
hk_cmake_fix_ep_atlas
branch
from
36c34c5 to
811a72a
Compare
0xc0170
approved these changes
Mar 12, 2021
|
I started CI meanwhile |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
This was referenced Mar 16, 2021
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The
EP_ATLASMbed board file structure creates a dependency onmbed-cellularandmbed-usb. However, these two library are not always needed when building applications that do not make use of the cellular connectivity or USB port.This PR makes changes to remove the dependency on
mbed-cellularandmbed-usbto make them optional.For more information see individual commit messages in this PR.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@0xc0170 @pan- @Patater @ARMmbed/team-nordic @MarceloSalazar