Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config macros for device-variant, freq-support and xtal config #14730

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Add config macros for device-variant, freq-support and xtal config #14730

merged 2 commits into from
Jul 21, 2021

Conversation

evandavey
Copy link
Contributor

Summary of changes

Fixes #14726 by adding config macros for device-variant, freq-support and xtal config.
Settings these macros to -1, the selection pins are used.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

This has been tested working on a target using an SX1262 module without using the select pins.

Reviewers

@ciarmcom ciarmcom requested review from a team June 3, 2021 00:30
@ciarmcom
Copy link
Member

ciarmcom commented Jun 3, 2021

@evandavey, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

ciarmcom commented Jun 7, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, @ARMmbed/mbed-os-connectivity, please complete review of the changes to move the PR forward. Thank you for your contributions.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 8, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 11, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-connectivity, please complete review of the changes to move the PR forward. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 11, 2021
0xc0170
0xc0170 previously approved these changes Jun 14, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2021

@ARMmbed/mbed-os-connectivity please review

@mergify mergify bot added needs: CI and removed needs: review labels Jun 14, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 14, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 17, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label Jun 25, 2021
@mergify mergify bot dismissed 0xc0170’s stale review June 26, 2021 09:06

Pull request has been modified.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 27, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 2, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2021

@evandavey Please remove the merge commit (rebase instead)

@ARMmbed/mbed-os-connectivity Please review

@evandavey evandavey force-pushed the fix/sx126x-select-pins branch from f5ed5d9 to 89789f2 Compare July 20, 2021 08:33
@evandavey
Copy link
Contributor Author

@0xc0170 - sorry, merge should be fixed now.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 20, 2021
@mbed-ci
Copy link

mbed-ci commented Jul 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 21, 2021
@0xc0170 0xc0170 merged commit e060c8c into ARMmbed:master Jul 21, 2021
@mergify mergify bot removed the ready for merge label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SX126X Select Pins
5 participants
@evandavey @ciarmcom @0xc0170 @mbed-ci @mbedmain