-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32WL LORA: HW specific out of STM32WL_LoRaRadio class #14734
Conversation
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is weak function really needed ? Seems like based on the state that is valid for everyone, just the ctrl1-3 changes its values. or is there more that can come in?
wondering if config would be sufficient for this or we need a weakly function
I have discussed with some LORA experts, and I understand that our HW reference design currently supports 4 antenna switch state, which are then configurable thanks to 3 GPIOs. |
@niondir what your custom function look like, if you just use one pin ? |
This pull request has automatically been marked as stale because it has had no recent activity. , please complete review of the changes to move the PR forward. Thank you for your contributions. |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 With this fix I can simply build my own method just containing my pins. That's great. Kind regards |
Summary of changes
Some code in STM32WL_LoRaRadio class was specific to NUCLEO_WL55JC HW,
and not general to STM32WL
It is then now compiled in another file.
Function is weak, and can be / has to be updated in each HW application
Should fix #14714
@niondir @ludoch-stm
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers