Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fcntl setting improvement, #14749

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

tymoteuszblochmobica
Copy link
Contributor

Summary of changes

Improve getting/setting O_NONBLOCK option in fcntl() implement to provide stable file handle based socket operations.

Impact of changes

No impact

Migration actions required

Not needed

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-
@ATmobica

@mergify mergify bot added the needs: work label Jun 8, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 8, 2021
@ciarmcom ciarmcom requested review from pan- and a team June 8, 2021 23:30
@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@tymoteuszblochmobica, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

ciarmcom commented Jun 9, 2021

@tymoteuszblochmobica, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

pan-
pan- previously requested changes Jun 9, 2021
platform/source/mbed_retarget.cpp Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

@tymoteuszblochmobica Please add details to the commit message, it helps a reader to understand it better (I do not know what was wrong before and how it is being addressed here).

@mergify mergify bot dismissed pan-’s stale review June 9, 2021 13:37

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@pan-
Copy link
Member

pan- commented Jun 17, 2021

@0xc0170 Anything else you need from us ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 17, 2021

All good, I'll take care of travis (reopening this PR) and we should be green.

@0xc0170 0xc0170 closed this Jun 17, 2021
@mergify mergify bot removed the component: core label Jun 17, 2021
@mergify mergify bot removed needs: CI release-type: patch Indentifies a PR as containing just a patch labels Jun 17, 2021
@0xc0170 0xc0170 reopened this Jun 17, 2021
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Jun 17, 2021
@0xc0170 0xc0170 merged commit c358ab2 into ARMmbed:master Jun 17, 2021
@mergify mergify bot removed the ready for merge label Jun 17, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants