Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Update mbed-coap to version 5.1.11 #14770

Merged
merged 1 commit into from
Jun 21, 2021
Merged

mbed-os-5.15: Update mbed-coap to version 5.1.11 #14770

merged 1 commit into from
Jun 21, 2021

Conversation

anttiylitokola
Copy link
Contributor

Summary of changes

Block-Wise request (block1) error handling improvements:

  • Removed SN_COAP_BLOCKWISE_MAX_TIME_DATA_STORED usage. Block-Wise requests will now follow normal retranmission rules.
  • Process block1 responses only once. If response is coming in wrong order just ignore it wait next response to happen.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@teetak01 @AnttiKauppila

[mbed-os-5.15] Update mbed-coap to version 5.1.11
a0f8c17 
Block-Wise request (block1) error handling improvements:
 * Removed SN_COAP_BLOCKWISE_MAX_TIME_DATA_STORED usage. Block-Wise requests will now follow normal retranmission rules.
 * Process block1 responses only once. If response is coming in wrong order just ignore it wait next response to happen.
@ciarmcom
Copy link
Member

@anttiylitokola, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team June 14, 2021 07:00
@mergify mergify bot added needs: CI and removed needs: review labels Jun 16, 2021
@0xc0170 0xc0170 requested a review from andypowers June 16, 2021 13:38
andypowers
andypowers approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 17, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 changed the title [mbed-os-5.15] Update mbed-coap to version 5.1.11 mbed-os-5.15: Update mbed-coap to version 5.1.11 Jun 21, 2021
@0xc0170 0xc0170 merged commit b87dc20 into ARMmbed:mbed-os-5.15 Jun 21, 2021
@mergify mergify bot removed the ready for merge label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@teetak01 teetak01 teetak01 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anttiylitokola @ciarmcom @0xc0170 @mbed-ci @teetak01 @andypowers