Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: AT command fix - hex string shouldn't be quoted on bc95 #14922

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Cellular: AT command fix - hex string shouldn't be quoted on bc95 #14922

merged 1 commit into from
Jul 20, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

BC95 spec doesn't require quotes for the hex string for the NSOST command. This retains default at handler behaviour unchanged and allows an optional parameter to disable it for devices that don't need it at driver level.

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm paul-szczepanek-arm mentioned this pull request Jul 14, 2021
Closed
@paul-szczepanek-arm
Copy link
Member Author

Fix for #14918

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 14, 2021
@ciarmcom ciarmcom requested a review from a team July 14, 2021 21:00
@ciarmcom
Copy link
Member

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@paul-szczepanek-arm
Copy link
Member Author

@alcheagle Can you review?

pan-
pan- approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition. The default parameter preserve existing behavior.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 15, 2021
@andreagilardoni
Copy link
Contributor

Thanks @paul-szczepanek-arm

@ciarmcom ciarmcom added the stale Stale Pull Request label Jul 16, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 16, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 16, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 16, 2021
@0xc0170 0xc0170 merged commit 2bb1539 into master Jul 20, 2021
@mergify mergify bot removed the ready for merge label Jul 20, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
@0xc0170 0xc0170 deleted the at-handler-fix branch October 5, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreagilardoni andreagilardoni andreagilardoni approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@pan- pan- pan- approved these changes

Assignees
No one assigned
Labels
component: connectivity release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paul-szczepanek-arm @ciarmcom @andreagilardoni @0xc0170 @mbed-ci @pan- @mbedmain