Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard Pin Names validation script update #14939

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Standard Pin Names validation script update #14939

merged 3 commits into from
Jul 22, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

2 new tests:

@gpsimenos @MarceloSalazar

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 20, 2021
@ciarmcom ciarmcom requested a review from a team July 20, 2021 15:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Jul 21, 2021
View reviewed changes
hal/tests/pinvalidate/pinvalidate.py
@@ -56,7 +56,7 @@ def find_target_by_path(target_path):

with open(target_path) as pin_names_file:
pin_names_file_content = pin_names_file.read()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove spaces in separate commit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyCharm has removed them automatically...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove spaces in separate commit

Done!

@mergify mergify bot dismissed 0xc0170’s stale review July 21, 2021 09:17

Pull request has been modified.

@0xc0170 0xc0170 requested a review from gpsimenos July 21, 2021 09:30
gpsimenos
gpsimenos previously approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@gpsimenos gpsimenos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, otherwise LGTM!

hal/tests/pinvalidate/pinvalidate.py Outdated
def legacy_arduino_uno_check(arduino_form_factor):
invalid_items = []
if arduino_form_factor == True:
message = "ARDUINO form factor is deprecated, should be replaced by ARDUIN_UNO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message = "ARDUINO form factor is deprecated, should be replaced by ARDUIN_UNO"
message = "ARDUINO form factor is deprecated, should be replaced by ARDUINO_UNO"

@mergify mergify bot added needs: CI and removed needs: review labels Jul 21, 2021
0xc0170
0xc0170 previously approved these changes Jul 21, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2021

I'll wait with CI until the typo is fixed.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jul 22, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@jeromecoutant
Copy link
Collaborator Author

I'll wait with CI until the typo is fixed.

Done

@mergify mergify bot dismissed stale reviews from 0xc0170 and gpsimenos July 22, 2021 11:56

Pull request has been modified.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 22, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0f5e062 into ARMmbed:master Jul 22, 2021
@0xc0170 0xc0170 removed the needs: CI label Jul 22, 2021
@jeromecoutant jeromecoutant deleted the PR_PIN_ALIAS branch July 22, 2021 13:20
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@gpsimenos gpsimenos gpsimenos left review comments

Assignees
No one assigned
Labels
component: hal release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @gpsimenos @mbedmain