Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFM: Add missing IPC file for PSA Firmware Update #14945

Merged
merged 1 commit into from
Jul 23, 2021
Merged

TFM: Add missing IPC file for PSA Firmware Update #14945

merged 1 commit into from
Jul 23, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 22, 2021

Summary of changes

This PR tries to add one missing file exported by TF-M, which is necessary for PSA Firmware Update API.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2021
@ciarmcom ciarmcom requested a review from a team July 22, 2021 08:30
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

LDong-Arm
LDong-Arm approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccli8, it's a good catch.

Could you please also raise a PR to update tfm_ns_import.yaml in the mbed-os-tf-m-regression-tests repo as per ARMmbed/mbed-os-tf-m-regression-tests#120? Thanks in advance!

@mergify mergify bot added needs: CI and removed needs: review labels Jul 22, 2021
@LDong-Arm LDong-Arm requested a review from a team July 22, 2021 09:13
@ccli8
Copy link
Contributor Author

ccli8 commented Jul 22, 2021

@LDong-Arm Done with ARMmbed/mbed-os-tf-m-regression-tests#123

@LDong-Arm LDong-Arm self-requested a review July 22, 2021 09:39
LDong-Arm
LDong-Arm reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The firmware update API is not current available on some targets (e.g. Musca S1), so let me think how we can handle this...
Also, the file needs to be added to the CMake lists.

@LDong-Arm LDong-Arm self-requested a review July 22, 2021 09:43
LDong-Arm
LDong-Arm previously requested changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the file to platform/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_LATEST/CMakeLists.txt to support CMake build.

It's fine to add this file. On a target that doesn't support Firmware Update, compilation still works, and any attempt to call the Firmware Update API returns a runtime error which is good enough.

@ccli8 ccli8 force-pushed the nuvoton_tfm_missing_update branch from 25d51da to 55506da Compare July 23, 2021 01:14
@mergify mergify bot dismissed LDong-Arm’s stale review July 23, 2021 01:15

Pull request has been modified.

@ccli8
TFM: Add missing IPC file for PSA Firmware Update
d5130d3 
On a target that doesn't support Firmware Update, compilation still works, and any attempt to call the Firmware Update API returns a runtime error which is good enough.
@ccli8 ccli8 force-pushed the nuvoton_tfm_missing_update branch from 55506da to d5130d3 Compare July 23, 2021 01:28
@ccli8
Copy link
Contributor Author

ccli8 commented Jul 23, 2021

Please add the file to platform/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_LATEST/CMakeLists.txt to support CMake build.

@LDong-Arm Updated CMakeLists.txt

LDong-Arm
LDong-Arm approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: work labels Jul 23, 2021
@LDong-Arm LDong-Arm requested a review from a team July 23, 2021 09:23
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 23, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 23, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_tfm-integration ✔️

@0xc0170 0xc0170 merged commit efaf159 into ARMmbed:master Jul 23, 2021
@mergify mergify bot removed the ready for merge label Jul 23, 2021
@ccli8 ccli8 deleted the nuvoton_tfm_missing_update branch July 26, 2021 00:40
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: core component: security release-version: 6.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @mbedmain