-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2354: Fix TF-M 1.4 #15078
M2354: Fix TF-M 1.4 #15078
Conversation
1. In TF-M, fix NSPE interrupt-disabled NSC call broken. Check: https://developer.trustedfirmware.org/T966 2. In TF-M, enable mcuboot log enabled forcibly. This is to help check firmware update process. 3. Update readme and script
@ccli8, thank you for your changes. |
@LDong-Arm Same as #14441, this PR changes frozen Then this PR can land in 6.15? Otherwise, M2354 will break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccli8 Thanks for the PR. How is "NSPE interrupt-disabled NSC call broken" reproduced?
Anyway, given that the TF-M code in https://github.com/OpenNuvoton/trusted-firmware-m/tree/nuvoton_mbed_m2354_tfm-1.4 has new commits added, updating binaries in mbed-os is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccli8 (As a follow-up) If a more verbose boot log is helpful with firmware update, could you please raise a PR to mbed-os-tf-m-regression-tests to pass additional cmake options during TF-M build, at least when the target is NU_M2354?
CI started |
On Mbed, call
nuvoton_mbed_m2354_tfm-1.4 has enabled it |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
This PR, following #15050, tries to fix NSC call broken on M2354 with TF-M 1.4 upgrade. It has the following modifications:
Pull request type
Test results