Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strrchr() not declared for IAR #15222

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Feb 7, 2022

Summary of changes

For IAR, strrchr() is used in MBED_FILENAME macro definition. Declare it explicitly to fix compile error when MBED_FILENAME is expanded.

#elif defined(__ICCARM__)
#define MBED_FILENAME (strrchr(__FILE__, '/') ? strrchr(__FILE__, '/') + 1 : strrchr(__FILE__, '\\') ? strrchr(__FILE__, '\\') + 1 : __FILE__)

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

For IAR, strrchr() is used in MBED_FILENAME macro definition. Declare it via string.h to fix compile error when MBED_FILENAME is expanded.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 7, 2022
@ciarmcom
Copy link
Member

ciarmcom commented Feb 7, 2022

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 7, 2022

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 7, 2022
@mbed-ci
Copy link

mbed-ci commented Feb 7, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 7, 2022

This bug was introduced recently, adding MBED_FILENAME to the error msg. Thanks for fixing it

@0xc0170 0xc0170 merged commit f515608 into ARMmbed:master Feb 7, 2022
@mergify mergify bot removed the ready for merge label Feb 7, 2022
@ccli8 ccli8 deleted the nuvoton_iar_strrchr branch February 8, 2022 01:16
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants