Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M487: Fix crypto h/w port #15289

Merged
merged 2 commits into from
May 30, 2022
Merged

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented May 24, 2022

Summary of changes

This PR tries to fix crypto port on NUMAKER_PFM_M487/NUMAKER_IOT_M487 targets, including:

  1. Fix typo with DES
  2. ECC doesn't support P + Q when P and Q are the same. Workaround by 2*P.

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 2 commits May 24, 2022 16:37
Engine doesn't support P + Q when P and Q are the same. Workaround by 2*P
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 24, 2022
@ciarmcom ciarmcom requested a review from a team May 24, 2022 10:30
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 30, 2022
@mbed-ci
Copy link

mbed-ci commented May 30, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants