Make STM32F412xE targets build #15299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to inherit the STM32F412xE target makes the linker fail, since __CRASH_DATA_RAM_START__ is not present. Comparing LD scripts with the STM32F412xG (which has active targets) it seems that the xE variant has missed some updates somewhere. Since the LD scripts are otherwise identical, copying the (working) ones from STM32F412xG seems to do the trick. Also added flash_data.h which was missing and needed here and there (copied from xG and updated to fit the xE flash layout).
ciarmcom
added
the
release-type: patch
|
@mikrodust-henrikp, thank you for your changes. |
|
2 comments before review:
|
I've added the MCU_STM32F412xE in targets.json as well. As for the crash data feature that probably should be per board, so leaving that for later. |
0xc0170
approved these changes
Jun 23, 2022
|
@jeromecoutant are you happy with the changes? |
jeromecoutant
added a commit
to ARMmbed/stm32customtargets
that referenced
this pull request
Jun 27, 2022
|
Ci started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Trying to inherit the STM32F412xE target makes the linker fail, since
CRASH_DATA_RAM_START is not present. Comparing LD scripts with the
STM32F412xG (which has active targets) it seems that the xE variant has
missed some updates somewhere. Since the LD scripts are otherwise
identical, copying the (working) ones from STM32F412xG seems to do the
trick.
Also added flash_data.h which was missing and needed here and there
(copied from xG and updated to fit the xE flash layout).
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers