LoRaWAN AS923 Add SUB_REGION AS1..AS4 #15320

dgoo2308 · 2022-08-11T08:55:23Z

Summary of changes

This Change add sub regions for AS923 according to the https://resources.lora-alliance.org/technical-specifications/rp2-1-0-3-lorawan-regional-parameters

Impact of changes

Able to use LoRaWAN in countries that moved to AS923-AS2, AS3 and AS4, while defaulting to AS1.
Added in connectivity/lorawan/mbed_lib.json a setting that defaults to AS1 sub region and thus defaults to the traditional AS923 Region.

"phy-as923-sub-region" : {
            "help": "AS923 sub region: AS1, AS2, AS3, AS4",
            "value": "AS1"
        }

Migration actions required

none

Documentation

None,

add lora.phy-as923-sub-region in the mbed_app.json setting as per Lorawan mbed_lib.json to define the AS923 sub region.

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Tested connectivity and data with RAK7268 Gateway in AS1/AS2/AS3 and AS4 Sub-region.

AS1:

No changes in parameters for frequency since the AS923-AS1 represents the traditional AS923 as per rp2-1-0-0.

AS2 packet log:

	Time	Freq.	RSSI	SNR	TxPwr	CRC	mod.	CR	DataRate	FCnt	AirTime	DevAddr	FPort	Payload Size
Unconfirmed Data Down	15:32:19	922.7	-	-	20	CRC	LORA	'4/5'	SF7BW125	7	'46'	020918C3	-	0
Unconfirmed Data Up	15:32:19	922.7	-41	11	-	CRC_OK	LORA	'4/5'	SF7BW250	7	'41'	020918C3	15	24
Unconfirmed Data Down	15:32:04	922.7	-	-	20	CRC	LORA	'4/5'	SF7BW125	6	'46'	020918C3	-	0
Unconfirmed Data Up	15:32:04	922.7	-41	10	-	CRC_OK	LORA	'4/5'	SF7BW250	6	'39'	020918C3	15	24
Unconfirmed Data Down	15:31:29	922.7	-	-	20	CRC	LORA	'4/5'	SF7BW125	5	'46'	020918C3	-	0
Unconfirmed Data Up	15:31:29	922.7	-36	11	-	CRC_OK	LORA	'4/5'	SF7BW250	4	'39'	020918C3	15	24
Unconfirmed Data Down	15:31:13	922.7	-	-	20	CRC	LORA	'4/5'	SF7BW125	4	'46'	020918C3	-	0
Unconfirmed Data Up	15:31:13	922.7	-34	10.3	-	CRC_OK	LORA	'4/5'	SF7BW250	3	'41'	020918C3	15	23
Unconfirmed Data Down	15:30:57	922.4	-	-	20	CRC	LORA	'4/5'	SF10BW125	3	'371'	020918C3	-	0
Unconfirmed Data Up	15:30:57	922.4	-31	13.3	-	CRC_OK	LORA	'4/5'	SF10BW125	2	'494'	020918C3	15	23
Unconfirmed Data Down	15:30:40	921.6	-	-	20	CRC	LORA	'4/5'	SF10BW125	2	'371'	020918C3	-	0
Unconfirmed Data Up	15:30:40	921.6	-31	13.5	-	CRC_OK	LORA	'4/5'	SF10BW125	1	'494'	020918C3	15	23
Unconfirmed Data Down	15:30:23	921.8	-	-	20	CRC	LORA	'4/5'	SF10BW125	1	'330'	020918C3	-	0
Unconfirmed Data Up	15:30:23	921.8	-31	10.3	-	CRC_OK	LORA	'4/5'	SF10BW125	0	'453'	020918C3	15	23
Join Accept	15:30:17	921.6	-	-	20	CRC	LORA	'4/5'	SF10BW125	-	'453'	-	-	-
Join Request	15:30:17	921.6	-32	12.8	-	CRC_OK	LORA	'4/5'	SF10BW125	-	'371'	-	-	-

AS3 packet log:

	Time	Freq.	RSSI	SNR	TxPwr	CRC	mod.	CR	DataRate	FCnt	AirTime	DevAddr	FPort	Payload Size
Unconfirmed Data Down	15:47:08	917.9	-	-	20	CRC	LORA	'4/5'	SF7BW125	4	'46'	028CE454	-	0
Unconfirmed Data Up	15:47:08	917.9	-35	11.5	-	CRC_OK	LORA	'4/5'	SF7BW250	3	'41'	028CE454	15	23
Unconfirmed Data Down	15:46:52	916.8	-	-	20	CRC	LORA	'4/5'	SF10BW125	3	'371'	028CE454	-	0
Unconfirmed Data Up	15:46:52	916.8	-32	13	-	CRC_OK	LORA	'4/5'	SF10BW125	2	'494'	028CE454	15	23
Unconfirmed Data Down	15:46:34	917.2	-	-	20	CRC	LORA	'4/5'	SF10BW125	2	'371'	028CE454	-	0
Unconfirmed Data Up	15:46:34	917.2	-32	13.3	-	CRC_OK	LORA	'4/5'	SF10BW125	1	'494'	028CE454	15	23
Unconfirmed Data Down	15:46:18	916.8	-	-	20	CRC	LORA	'4/5'	SF10BW125	1	'330'	028CE454	-	0
Unconfirmed Data Up	15:46:18	916.8	-32	12.8	-	CRC_OK	LORA	'4/5'	SF10BW125	0	'453'	028CE454	15	23
Join Accept	15:46:12	916.8	-	-	20	CRC	LORA	'4/5'	SF10BW125	-	'453'	-	-	-
Join Request	15:46:12	916.8	-34	13.5	-	CRC_OK	LORA	'4/5'	SF10BW125	-	'371'	-	-	-

AS4 packet log:

	Time	Freq.	RSSI	SNR	TxPwr	CRC	mod.	CR	DataRate	FCnt	AirTime	DevAddr	FPort	Payload Size
Unconfirmed Data Down	15:52:46	918.6	-	-	20	CRC	LORA	'4/5'	SF7BW125	4	'46'	020025B6	-	0
Unconfirmed Data Up	15:52:46	918.6	-35	12.5	-	CRC_OK	LORA	'4/5'	SF7BW250	3	'41'	020025B6	15	23
Unconfirmed Data Down	15:52:30	918.7	-	-	20	CRC	LORA	'4/5'	SF10BW125	3	'371'	020025B6	-	0
Unconfirmed Data Up	15:52:30	918.7	-32	12.8	-	CRC_OK	LORA	'4/5'	SF10BW125	2	'494'	020025B6	15	23
Unconfirmed Data Down	15:52:14	918.3	-	-	20	CRC	LORA	'4/5'	SF10BW125	2	'371'	020025B6	-	0
Unconfirmed Data Up	15:52:12	918.3	-34	13.5	-	CRC_OK	LORA	'4/5'	SF10BW125	1	'494'	020025B6	15	23
Unconfirmed Data Down	15:51:56	917.5	-	-	20	CRC	LORA	'4/5'	SF10BW125	1	'330'	020025B6	-	0
Unconfirmed Data Up	15:51:56	917.5	-33	13.5	-	CRC_OK	LORA	'4/5'	SF10BW125	0	'453'	020025B6	15	23
Unconfirmed Data Up	15:51:56	917.9	-94	-15.3	-	CRC_OK	LORA	'4/5'	SF10BW125	0	'453'	020025B6	15	23
Join Accept	15:51:50	917.3	-	-	20	CRC	LORA	'4/5'	SF10BW125	-	'453'	-	-	-
Join Request	15:51:50	917.3	-34	13.8	-	CRC_OK	LORA	'4/5'	SF10BW125	-	'371'	-	-	-

Reviewers

ciarmcom · 2022-08-11T09:00:13Z

@dgoo2308, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2022-08-11T09:51:46Z

CI started

mbed-ci · 2022-08-11T10:25:56Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

0xc0170 · 2022-08-11T13:59:51Z

I've missed basic check - style failing - please review, run astyle and commit.

Pull request has been modified.

ciarmcom · 2022-08-11T15:30:14Z

@dgoo2308, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

connectivity/lorawan/lorastack/phy/LoRaPHYAS923.cpp

Pull request has been modified.

0xc0170 · 2022-08-25T13:42:35Z

CI started

mbed-ci · 2022-08-25T14:18:17Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

LoRaWAN AS923 Add SUB_REGION AS1..AS4

199c856

ciarmcom added the release-type: feature label Aug 11, 2022

ciarmcom requested a review from a team August 11, 2022 09:00

ciarmcom added needs: review component: connectivity labels Aug 11, 2022

0xc0170 previously approved these changes Aug 11, 2022

View reviewed changes

fix styling with astyle for LoRaPHYAS923.cpp

30a1560

ciarmcom requested a review from a team August 11, 2022 15:30

0xc0170 previously approved these changes Aug 17, 2022

View reviewed changes

0xc0170 reviewed Aug 17, 2022

View reviewed changes

connectivity/lorawan/lorastack/phy/LoRaPHYAS923.cpp Outdated Show resolved Hide resolved

apply astyle patch

3508ec2

0xc0170 self-requested a review August 18, 2022 10:17

0xc0170 added needs: CI and removed needs: review labels Aug 25, 2022

0xc0170 approved these changes Aug 25, 2022

View reviewed changes

0xc0170 merged commit 807fd79 into ARMmbed:master Aug 25, 2022

mergify bot added ready for merge and removed needs: CI ready for merge labels Aug 25, 2022

saheerb added release-version: 6.17.0 Release-pending labels Feb 23, 2023

saheerb added the release-version: 6.18.0 label Feb 28, 2023

mbedmain removed release-type: feature Release-pending labels Feb 28, 2023

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LoRaWAN AS923 Add SUB_REGION AS1..AS4 #15320

LoRaWAN AS923 Add SUB_REGION AS1..AS4 #15320

dgoo2308 commented Aug 11, 2022

ciarmcom commented Aug 11, 2022

0xc0170 commented Aug 11, 2022

mbed-ci commented Aug 11, 2022

0xc0170 commented Aug 11, 2022

ciarmcom commented Aug 11, 2022

0xc0170 commented Aug 25, 2022

mbed-ci commented Aug 25, 2022

LoRaWAN AS923 Add SUB_REGION AS1..AS4 #15320

LoRaWAN AS923 Add SUB_REGION AS1..AS4 #15320

Conversation

dgoo2308 commented Aug 11, 2022

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

AS1:

AS2 packet log:

AS3 packet log:

AS4 packet log:

Reviewers

ciarmcom commented Aug 11, 2022

0xc0170 commented Aug 11, 2022

mbed-ci commented Aug 11, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

0xc0170 commented Aug 11, 2022

ciarmcom commented Aug 11, 2022

0xc0170 commented Aug 25, 2022

mbed-ci commented Aug 25, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts