Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAN: read only up to 8 bytes #15375

Merged
merged 1 commit into from
Feb 9, 2023
Merged

CAN: read only up to 8 bytes #15375

merged 1 commit into from
Feb 9, 2023

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 16, 2023

Summary of changes

If HAL implementation writes more than 8 bytes of data, error immediately. CANMessage defines only 8 bytes of data, lenght cannot be > 8.

This fixes #15361

Same fix as for Mbed OS 6.x : #15374

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170
CAN: read only up to 8 bytes
7a3f1bc 
If HAL implementation writes more than 8 bytes of data, error immediately.
CANMessage defines only 8 bytes of data, lenght cannot be > 8.

This fixes ARMmbed#15361

Signed-off-by: Martin Kojtal <martin.kojtal@arm.com>
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 18, 2023

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jan 18, 2023
@0xc0170 0xc0170 requested review from andypowers and saheerb January 18, 2023 10:02
andypowers
andypowers approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2023

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@saheerb saheerb merged commit 83fc7ed into ARMmbed:mbed-os-5.15 Feb 9, 2023
@saheerb
Copy link
Contributor

saheerb commented Feb 9, 2023

Due to some infra structure issue, jenkins-ci/example-test-lts failed. Rerun solved the issue. But continuous-integration/jenkins/pr-head will still show as failed. Rather than rerunning the entire pipeline, merging it in as sub jobs have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@saheerb saheerb Awaiting requested review from saheerb

Assignees
No one assigned
Labels
Release review required release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xc0170 @mbed-ci @saheerb @andypowers