Enable uvisor on Beetle #2518
Merged
Enable uvisor on Beetle #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results: |
|
@AlessandroA Could you please review? |
| blx r0 | ||
| /* The call to uvisor_init() happens independently of uVisor being enabled or | ||
| * not, so it is conditionally compiled only based on FEATURE_UVISOR. */ | ||
| #ifdef FEATURE_UVISOR |
There was a problem hiding this comment.
Could you change this to #if defined(FEATURE_UVISOR) && defined(TARGET_UVISOR_SUPPORTED)?
There was a problem hiding this comment.
I will do in the next iteration, thanks.
This patch modifies: * the Beetle GCC ARM linker script * the Beetle startup code in order to define the memory regions that enable uvisor. Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
fvincenzo
force-pushed
the
master
branch
2 times, most recently
from
3f09307 to
f44bff5
Compare
|
@AlessandroA I made the changes as per review. Could you please let me know if my code is OK to go now? 😄 |
|
LGTM! 👍 |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 805 Build failed! |
|
[Build 891] |
|
@fvincenzo Some CI test failures. Could you rebase on master and run mbed test for these boards / compiler combinitions? |
This patch backports the virtual NVIC mechanish from CMSIS 5 for the Cortex M3 architecture in order to support uvisor in this MCU class. Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
This patch adds CMSIS 5 virtual NVIC compliancy in order to support uvisor. Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
This patch disables the fcache stats into mbed_sdk_init if uvisor is defined in order to prevent MEMMANAGEMENT faults during boot. Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
This patch adds Beetle platform to uvisor importer. Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
|
@sg @0xc0170 I rebased the code. The patch set requires changes in the platforms that are using CM3 because it contains a backport of virtual NVIC from cmsis 5 (as explained in the patchset cover). Without the backport uvisor will not work. I opened an issue #2641 to track this since I do not have other boards except beetle to test it. |
|
/morph test |
If thats the case we should upgrade all CMSIS files to a newer version and patch the target code. Thanks for opening the issue. |
|
@sg No problem. Based on this could you please merge my change once the tests are complete? |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 833 Test failed! |
|
morph test looks ok, need to go over a timing test edge case to prevent this from happening in the future. |
|
retest |
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 2669: Added u-blox C029 target ARMmbed/mbed-os#2669 2707: [EFM32] Add IAR support for remaining Silicon Labs targets ARMmbed/mbed-os#2707 2819: MultiTech xDot platform support - 09.26.2016 ARMmbed/mbed-os#2819 2827: include MultiTech xDot in mbed 5 releases ARMmbed/mbed-os#2827 Fixes and Changes 2522: Add CThunk for CM7 ARMmbed/mbed-os#2522 2518: Enable uvisor on Beetle ARMmbed/mbed-os#2518 2571: STM32F7 - Add asynchronous serial ARMmbed/mbed-os#2571 2616: STM32F3xx - Add Serial Flow Control pins + enable it ARMmbed/mbed-os#2616 2619: NUCLEO_L152RE - Add Serial Flow Control ARMmbed/mbed-os#2619 2620: NUCLEO_F429ZI - Add SERIAL_FC macro ARMmbed/mbed-os#2620 2666: [EFM32] Microsecond ticker optimization ARMmbed/mbed-os#2666 2681: STM32F0xx - Add support of ADC internal channels ARMmbed/mbed-os#2681 2687: [NRF5] Add fs_data symbol in data secton for gcc ARMmbed/mbed-os#2687 2696: Add device_has to all nrf51 devices ARMmbed/mbed-os#2696 2703: TARGET_NRF5: Changed 'serial_baud' implementation to support special baud rates. ARMmbed/mbed-os#2703 2704: DISCO_L476VG: add SPI nicknames ARMmbed/mbed-os#2704 2723: KSDK serial_api.c: Fix assertion error for ParityEven ARMmbed/mbed-os#2723 2463: [STM32L0] Add asynchronous serial ARMmbed/mbed-os#2463 2572: Fix STM32F407VG target name and LPC11U6X linker errors ARMmbed/mbed-os#2572 2698: DELTA_DFBM_NQ620 target ARMmbed/mbed-os#2698 2542: Dev spi asynch stm32f4 ARMmbed/mbed-os#2542 2650: STM32F3 - Add low power timer ARMmbed/mbed-os#2650 2415: [STM32F0] Add asynchronous serial ARMmbed/mbed-os#2415 2585: Added support for ADC only pins in LPC43xx ARMmbed/mbed-os#2585 2622: [STM32F4] Add asynchronous I2C ARMmbed/mbed-os#2622 2719: Updated ARM linker scripts for Kinetis platforms that use SDK 2.0 ARMmbed/mbed-os#2719 2728: Added ethernet and enabled IPV4 feature for the EVK-ODIN-W2/C029 target ARMmbed/mbed-os#2728 2747: [LPC11U68] Fix pin interrupt select offset ARMmbed/mbed-os#2747 2751: STM32L0xx - Add Serial Flow Control ARMmbed/mbed-os#2751 2753: [NUCLEO_F767ZI] Add CAN capability ARMmbed/mbed-os#2753 2759: STM32F0 - Add low power timer ARMmbed/mbed-os#2759 2763: STM32L1 - Add low power timer ARMmbed/mbed-os#2763 2764: STM32L4 - Add low power timer ARMmbed/mbed-os#2764 2771: STM32L4 - Update deepsleep implementation ARMmbed/mbed-os#2771 2775: Update KSDK SDHC driver for K64F & K66F ARMmbed/mbed-os#2775 2792: [NUCLEO_F303ZE] MBED-OS5 capability ARMmbed/mbed-os#2792 2762: STM32L0 - Add low power timer ARMmbed/mbed-os#2762 2761: STM32F7 - Add low power timer ARMmbed/mbed-os#2761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the set of patches that enable uvisor on Beetle.
It required some adaptation of the CMSIS file for the Cortex M3 covered in the patch "Backport virtual NVIC mechanism from CMSIS 5 on CM3". This change impacts even the other platforms that implement cmsis_nvic.c/h.
I extensively tested it on beetle and the results are attached.