Remove "lib" and "lib64" from the mbed-OS .gitignore file: they do no… #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t seem to be required and lib is used as a directory name in a recent (u-blox) mbedOS target submission, so ignoring the files under that directory becomes a problem.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.gitignorefile that arrives with mbed haslibin its list. The u-blox mbed platform we have just submitted a pull request for (#2705) has a set of files, in a tree that is provided to us, with a sub-directory namedlib('cos those files are considered part of a library). So this is a real pain for us: git entirely ignores changes in somewhat important files.After discussion with @bridadan and @screamerbg in issue #2706, this pull request is submitted to remove both
libandlib64from the git ignore list.