Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of metadata types #280

Open
brancomat opened this issue Nov 26, 2021 · 2 comments
Open

Documentation of metadata types #280

brancomat opened this issue Nov 26, 2021 · 2 comments

Comments

@brancomat
Copy link
Member

The official documentation (https://arpa-simc.github.io/arkimet/) lacks a description of all metadata types.

There's also some 10-years-old doc made by @enrenr and @spanezz here: https://github.com/ARPA-SIMC/arkimet/tree/master/doc/scan that goes a bit further describing how the single metadata type is composed for different formats that seems useful and could be incorporated in the official documentation.

And that brings us to the age-old issue of how to be sure that the doc is updated each time the code is updated (spoiler alert: the doc isn't updated).

@spanezz
Copy link
Contributor

spanezz commented Jan 27, 2022

I'm attempting to do it by implementing arki-dump --doc-metadata, with the intention to keep each metadata item's documentation as close as possible to its implementation

@spanezz
Copy link
Contributor

spanezz commented Jan 27, 2022

We have an initial inventory and documentation attempt at https://github.com/ARPA-SIMC/arkimet/blob/master/doc/metadata.rst

This is updated manually by running something like ./run-local arki-dump --doc-metadata > doc/metadata.rst. On the implementation side, I added a write_documentation method to all metadata item implementations in arki/types. The presence of the documentation method is enforced by the compiler. I tried to store documentation, where possible, alongside the class definitions in header files.

Some metadata elements are more documented than others: for example, I don't really know what the ODIM specific metadata refers to, and I'm not the right person to add stable references to the WMO Manual on Codes to annotate GRIB and BUFR values.

This might be something that grows over time, now that we have a place to write this documentation, and possibly with the help of domain-specific experts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants