-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if a resource has duration of 0 minutes, don't show minutes at all on the description/right of the resource #85
Conversation
Is this PR similar to what is solved via #88 ? and specifically is |
Yes, they are similar. #88 builds on this and shows the updated duration too. |
You are welcome 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks clean, I'll check now locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for development branch
ok looks good. One litte request would be to be discussed: when the module is removed and added again one has no way of resetting to the old time/get a notification of the change?, as it seems the new manual set time is saved |
I don't fully understand the question. Once you've edited the duration, the new time is only added to the current instance. The actual resource markdown does not change; it still contains the old duration. We could add a button for resetting to the initial time and/or a notification for when the duration changes |
Hides resource duration when the time is 0 minutes
Fixes #8