Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a resource has duration of 0 minutes, don't show minutes at all on the description/right of the resource #85

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

saisilinus
Copy link
Collaborator

Hides resource duration when the time is 0 minutes

Fixes #8

@timmwille
Copy link
Member

Is this PR similar to what is solved via #88 ? and specifically is res.resource.duration always a product of the pre-set OR manual time/duration ? (I will also test locally ones I've overlooked the other PRs in detail, but looks good, thank you!)

@saisilinus
Copy link
Collaborator Author

Is this PR similar to what is solved via #88 ? and specifically is res.resource.duration always a product of the pre-set OR manual time/duration ? (I will also test locally ones I've overlooked the other PRs in detail, but looks good, thank you!)

Yes, they are similar. #88 builds on this and shows the updated duration too. res.resource.duration is always the pre-set duration. The manually changed duration can be displayed though and used in the calculations of the total time.

@saisilinus
Copy link
Collaborator Author

Is this PR similar to what is solved via #88 ? and specifically is res.resource.duration always a product of the pre-set OR manual time/duration ? (I will also test locally ones I've overlooked the other PRs in detail, but looks good, thank you!)

You are welcome 😀

@timmwille timmwille changed the base branch from main to development October 23, 2023 20:41
Copy link
Member

@timmwille timmwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks clean, I'll check now locally

Copy link
Member

@timmwille timmwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for development branch

@timmwille timmwille merged commit ffc417a into ASKnetCommunity:development Oct 23, 2023
@timmwille
Copy link
Member

ok looks good. One litte request would be to be discussed: when the module is removed and added again one has no way of resetting to the old time/get a notification of the change?, as it seems the new manual set time is saved

@saisilinus
Copy link
Collaborator Author

ok looks good. One litte request would be to be discussed: when the module is removed and added again one has no way of resetting to the old time/get a notification of the change?, as it seems the new manual set time is saved

I don't fully understand the question. Once you've edited the duration, the new time is only added to the current instance. The actual resource markdown does not change; it still contains the old duration. We could add a button for resetting to the initial time and/or a notification for when the duration changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if a resource has duration of 0 minutes, don't show minutes at all on the description/right of the resource
2 participants