Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SSOT로 묶을 수 있는 코드 정리 #85

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Refactor SSOT로 묶을 수 있는 코드 정리 #85

merged 8 commits into from
Aug 24, 2023

Conversation

mokhs00
Copy link
Member

@mokhs00 mokhs00 commented Aug 21, 2023

Close #65

Summary

  • SSOT로 묶을 수 있을만한 설정 데이터를 정리합니다.
  • 테스트 추가 (허용된 year 데이터만 존재해야 합니다.)

grayashh
grayashh previously approved these changes Aug 24, 2023
Copy link
Member

@grayashh grayashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍

data/people.ts Outdated Show resolved Hide resolved
src/lib/config.ts Outdated Show resolved Hide resolved
src/_pages/people/ScrollNavigation.tsx Outdated Show resolved Hide resolved
data/people.test.ts Outdated Show resolved Hide resolved
data/people.test.ts Outdated Show resolved Hide resolved
@mokhs00 mokhs00 changed the title Refactor SSOT로 묵을 수 있는 코드 정리 Refactor SSOT로 묶을 수 있는 코드 정리 Aug 24, 2023
@mokhs00 mokhs00 merged commit 08b930d into main Aug 24, 2023
1 check passed
@mokhs00 mokhs00 deleted the ISSUE-65 branch August 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

코드 응집도를 챙기면서 SSOT로 변경하기
3 participants