Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add style-vars extension #232

Merged
merged 1 commit into from
Nov 18, 2023
Merged

add style-vars extension #232

merged 1 commit into from
Nov 18, 2023

Conversation

SirVeggie
Copy link
Contributor

@SirVeggie SirVeggie commented Nov 18, 2023 •
edited
Loading

Info

https://github.com/SirVeggie/extension-style-vars

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Nov 18, 2023

nice, works as intended without issues

just a suggestion
I think it makes more sense to put your enable option in setting instead of a accordion
a user is not expected to change this option all the time
this way it declutter's the UI

@w-e-w w-e-w merged commit 583ef35 into AUTOMATIC1111:extensions Nov 18, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2023
@w-e-w @github-actions
Merge pull request #232 from SirVeggie/extensions
c06eca8
@SirVeggie
Copy link
Contributor Author

That's a good point, I moved the toggle to the settings tab. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirVeggie @w-e-w